engine icon indicating copy to clipboard operation
engine copied to clipboard

Published 20 hours ago • verified publisher icon flutter

iOS cleanup IOSurfaces when not visible

Open ColdPaleLight opened this issue 2 years ago • 3 comments

Fix https://github.com/flutter/flutter/issues/77621 based on this PR https://github.com/flutter/engine/pull/25400 and this comment https://github.com/flutter/flutter/issues/77621#issuecomment-836342415

Pre-launch Checklist

  • [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • [ ] I listed at least one issue that this PR fixes in the description above.
  • [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] I signed the [CLA].
  • [ ] All existing and new tests are passing.

ColdPaleLight avatar Mar 30 '22 14:03 ColdPaleLight

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Mar 30 '22 14:03 flutter-dashboard[bot]

@ColdPaleLight Is this still on your radar? (I think it's been ignored by reviewers because it's marked as a draft.)

Hixie avatar May 24 '22 23:05 Hixie

@ColdPaleLight Is this still on your radar? (I think it's been ignored by reviewers because it's marked as a draft.)

Yes, it is. I will finish it soon.

ColdPaleLight avatar May 24 '22 23:05 ColdPaleLight

@ColdPaleLight Friendly ping again. :-)

Hixie avatar Sep 27 '22 23:09 Hixie

@ColdPaleLight Friendly ping again. :-)

I've tried fixing those failing tests, but it didn't work. Maybe I need to reimplement this patch.

Closing it since it need more work to do.

ColdPaleLight avatar Sep 28 '22 09:09 ColdPaleLight