engine icon indicating copy to clipboard operation
engine copied to clipboard

Re-land "Partially Remove setSystemUiVisibility()"

Open camsim99 opened this issue 3 years ago • 0 comments

Re-lands PR #31092, with the following differences:

  1. Leaves usages of DEFAULT_SYSTEM_UI flag due to change in edge-to-edge mode becoming the Android standard after API 29 and the undesired effects of using the updated backwards compatible API, which caused a regression.*
  2. Suppresses deprecation warnings for the PlatformPlugin methods and DEFAULT_SYSTEM_UI flag usages where deprecated APIs cannot be completely removed.

*Ultimately, a migration to use these APIs should be made to streamline behavior across Android versions (see related issue).

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [x] I signed the CLA.
  • [ ] All existing and new tests are passing.

camsim99 avatar Mar 14 '22 18:03 camsim99