devtools icon indicating copy to clipboard operation
devtools copied to clipboard

Re-enable Flutter customer testing once `inspector_v2/inspector_integration_test.dart` is updated

Open bkonyi opened this issue 7 months ago • 2 comments

screenshot tests expand and collapse implementation widgets in inspector_v2/inspector_integration_test.dart is blocking https://github.com/flutter/flutter/pull/169229 from landing as it's using the number of widgets in the tree to find the correct button to select:

        // Expand the hidden group that contains the HeroControllerScope:
        final expandButton = findExpandCollapseButtonForNode(
          nodeDescription: '71 more widgets...', // This needs to be updated to 72
          isExpand: true,
        );

These tests ideally should be using keys to select specific nodes, but in the meantime, I'm going to disable DevTools customer testing until the above PR lands.

bkonyi avatar May 26 '25 22:05 bkonyi

@elliette

kenzieschmoll avatar May 27 '25 17:05 kenzieschmoll

Note: We will need to re-enable the golden checks (disabled in https://github.com/flutter/devtools/pull/9226) and update the goldens once https://github.com/flutter/flutter/pull/169229 lands and the Flutter candidate in DevTools has been updated.

elliette avatar May 30 '25 22:05 elliette