flutter
add health checks for breaking changes, changelogs, pubspecs, etc
Add a health check job that checks various things, such as changelog entries and proper semver.
Would avoid issues such as the one in https://github.com/flutter/devtools/pull/8291 where breaking changes are accidentally released in non-breaking versions.
I am not actually sure this works with repos that are a mixture of flutter and dart packages, we might need some extra functionality from the health check tool if this fails on the non-flutter packages.
Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [ ] I read the [Flutter Style Guide] recently, and have followed its advice.
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description above.
- [ ] I updated/added relevant documentation (doc comments with
///). - [ ] I added new tests to check the change I am making, or there is a reason for not adding tests.
cc @bkonyi I also see this failure https://github.com/flutter/devtools/actions/runs/10780298465 it looks like there is a transitive dep on a new GitHub action, and those have to be allow listed somehow. Any ideas?
cc @bkonyi I also see this failure https://github.com/flutter/devtools/actions/runs/10780298465 it looks like there is a transitive dep on a new GitHub action, and those have to be allow listed somehow. Any ideas?
Sorry for the delayed response. I'll be honest, I know nothing about GitHub actions 😬
@kenzieschmoll do you have any ideas how this check is set up? Maybe something in the admin settings for the repo?
It looks like it probably is in the settings for the repo, see https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository. We will need an admin to approve of this new action and add it to the list.
Does anybody know who an admin is for this repo? cc @devoncarew @kevmoo ?
Does anybody know who an admin is for this repo? cc @devoncarew @kevmoo ?
For repos in the flutter/ github org, you'll want @Piinks (and possibly others?).
@kenzieschmoll is an admin for this repo, I am not familiar with how the github actions are set up here.
I don't have the ability to add a new action, the text field is disabled for me:
@Piinks are you able to add the "peter-evans/find-comment@d0ee7939ee99ba35820c3e58de972e57ff8bb890" action?
Same, I also cannot edit the text field. 🤔 Asking the infra folks for advice
(triage): @Piinks Did the infra people have any advice?
Alas, they did not. 😞 Will take a look again in the new year, there may be an obscure setting that is causing this to be disabled.
Thanks @jakemac53 closed after syncing up offline, we don't have a path forward for this change currently.