devtools icon indicating copy to clipboard operation
devtools copied to clipboard
verified publisher icon flutter

Ide theme color not getting set certain UI elements

Open kenzieschmoll opened this issue 1 year ago • 2 comments

The lighter gray is getting passed in by the query parameters from the IDE, but it is not getting applied everywhere: Screenshot 2024-08-22 at 1 47 06 PM Screenshot 2024-08-22 at 1 52 07 PM Screenshot 2024-08-22 at 1 45 20 PM URL: Screenshot 2024-08-22 at 1 51 13 PM

kenzieschmoll avatar Aug 22 '24 20:08 kenzieschmoll

Also seeing this on the Network Panel:

Screenshot 2024-08-22 at 1 47 10 PM

elliette avatar Aug 22 '24 20:08 elliette

Performance panel:

Screenshot 2024-08-22 at 1 59 13 PM

Screenshot 2024-08-22 at 1 59 05 PM

Screenshot 2024-08-22 at 2 00 41 PM

elliette avatar Aug 22 '24 21:08 elliette

Investigating https://github.com/flutter/devtools/issues/8466, I've discovered why this happens:

  • We do not set the colorScheme in the Theme we construct from the IDE background color, so any color properties we access on colorScheme will not be set to work with the IDE theme.
  • Furthermore, DevToolsSharedColorScheme does not take into consideration the IDE theme: https://github.com/flutter/devtools/blob/3b73a655d85700b3b460c34691ba8b0e057eab17/packages/devtools_app_shared/lib/src/ui/theme/theme.dart#L343

elliette avatar Oct 30 '24 23:10 elliette

Fixed in https://github.com/flutter/devtools/pull/9144

elliette avatar May 02 '25 17:05 elliette