flutter
implemented har feature
- Export har feature added.
- Need some guidance regarding deserialising the har and offline support.
List which issues are fixed by this PR.
Please add a note to packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md if your change requires release notes. Otherwise, add the 'release-notes-not-required' label to the PR.
Pre-launch Checklist
- [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [ ] I read the Flutter Style Guide recently, and have followed its advice.
- [ ] I signed the CLA.
- [ ] I listed at least one issue that this PR fixes in the description above.
- [ ] I updated/added relevant documentation (doc comments with
///). - [ ] I added new tests to check the change I am making, or there is a reason for not adding tests.
If you need help, consider asking for help on Discord.
@kenzieschmoll @exaby73 When I disconnect the app loader keeps showing https://github.com/flutter/devtools/issues/7968
When I disconnect the app loader keeps showing #7968
This issue should be resolved if you merge with the master branch. Fix was here: https://github.com/flutter/devtools/pull/7992
@kenzieschmoll as I observed the offline functionality works in these ways :
- When the app gets disconnected, view offline data.
- Before connecting to the app, few screens support importing a file.
- While the app is connected user can still import a saved file, it disconnects the app and in goes in offline mode where dev can view the data.
I have implemented the 1st one (changes yet to be pushed as of now). Can you clarify which of these is req for network screen? this is my demo pr for 1st point from my forked repo - https://github.com/hrajwade96/devtools/pull/1 let me know your inputs
@bkonyi can you re-check the comments and mark them as resolved if they are addressed
@bkonyi can you re-check the comments and mark them as resolved if they are addressed
Sorry for the delay, I'll take a look.
All of my comments are basically addressed and this LGTM overall. I'll let @kenzieschmoll give final say on the PR. Thanks for your contribution!
All of my comments are basically addressed and this LGTM overall. I'll let @kenzieschmoll give final say on the PR. Thanks for your contribution!
Looking forward to contributing more in future, after this one is done!
I apologize, I had a pending review that I never hit submit on. Here are my recommendations.
oh ok, no issues
LGTM once all tests pass. Thanks for the feature!
Thank you for the review! I'll ensure all tests pass. Appreciate the feedback and support!
LGTM once all tests pass. Thanks for the feature!
@kenzieschmoll All the tests have passed can this be merged now? Or Anything else remaining?