devtools icon indicating copy to clipboard operation
devtools copied to clipboard

[Network Tab] Rework UI/UX on filters and buttons

Open TiffApps opened this issue 1 year ago • 5 comments

Hi, I wanted to point out a few things that I found annoying:

1 - The filter tab is very useful, but gets reset when the network tab is closed, making it annoying to rewrite filters every time I open it. For example, I get spammed by websocket requests and have to filter them with -s:101 every time I open this tab. I suggest the filters should be persistent (like the filters in VSC's Debug Console), saved as a preference. image

2 - The "Clear" button doesn't clear only the request logs, but also the filters, which is definitely not what I want when I click there (there is a "Reset to default" button and another "Clear" button to clear filters in the filter tab, and that should be enough). This "Clear" button should clear only the recorded request traffic and nothing else. image

3 - This last one is more a remark, but I can see two buttons with the same icon? Left one is to pause traffic, and right one is to resume it, so I guess the right one should be a "Play" icon. Or remove one of them and make the remaining one a toggle between Play/Pause. image

Let me know what you think about these! And huge thanks for fixing the errors lately on this network tool, it's so practical, I love it!

TiffApps avatar Mar 31 '23 07:03 TiffApps

All three of these suggestions sounds great.

kenzieschmoll avatar May 26 '23 21:05 kenzieschmoll

For suggestion 1, we may need more design consideration around this. We definitely wouldn't want to store text filters in preferences. Maybe we could have a checkbox filter (see the CPU profiler page for example) "Show websocket traffic" and something like that we could store to preferences.

We can start with implementing 2 & 3 though. @CoderDake

kenzieschmoll avatar Oct 18 '23 20:10 kenzieschmoll

Hello @kenzieschmoll ? Can i work on this issue?

jagrutatwork avatar Dec 10 '23 05:12 jagrutatwork

Hi @jagrutatwork. Yes, feel free to work on items 2 & 3 above. For 3, please take a look at the PauseResumeButtonGroup widget in DevTools - we can use that here too.

kenzieschmoll avatar Dec 12 '23 17:12 kenzieschmoll

Thanks @kenzieschmoll, I will take a look into it!

jagrutatwork avatar Dec 16 '23 06:12 jagrutatwork