devtools icon indicating copy to clipboard operation
devtools copied to clipboard

Bring Observatory timeline features into DevTools timeline

Open kenzieschmoll opened this issue 5 years ago • 3 comments

See Observatory -> DevTools Tracking Issue.

Feature requests from discussion @chinmaygarde and I had offline. These features are currently in Observatory and are used by the Engine team for debugging performance issues:

  • draw solid lines for VsyncFireCallback events. VsyncFireCallback indicates that we asked to draw a frame. The absence of the VsyncFireCallback means the engine is too busy, so we didn’t consider drawing a frame

  • adding arrows for flow events

  • background coloring for VsyncProcessCallback. Observatory signals these as gray and white alternating background colors. This event indicates that if you wanted to render a frame, now would be a good time Screen Shot 2020-07-30 at 1 42 17 PM

  • selecting multiple frames and looking at averages / standard deviations. This example is for several GPURasterizer::Draw events: Screen Shot 2020-07-30 at 1 42 41 PM

If we bring some of these features into DevTools, we should update this article accordingly.

kenzieschmoll avatar Jul 30 '20 20:07 kenzieschmoll

@chinmaygarde please add any context or details I may have missed. Thanks.

kenzieschmoll avatar Jul 30 '20 20:07 kenzieschmoll

Adding this to the Observatory migration tracking issue.

bkonyi avatar Mar 16 '22 19:03 bkonyi

Update: this issue will be resolved once Perfetto integration is complete.

bkonyi avatar Sep 30 '22 13:09 bkonyi

Closing this now that the embedded Perfetto trace viewer has shipped. Any new reports of missing features should be filed separately. If the Perfetto trace viewer is missing features that Catapult used to have, those feature requests should be filed against the google/perfetto repo: https://github.com/google/perfetto/issues

kenzieschmoll avatar Feb 13 '23 20:02 kenzieschmoll