devtools icon indicating copy to clipboard operation
devtools copied to clipboard

Validation on the input before connect request is triggered...

Open jwren opened this issue 5 years ago • 2 comments

On the launch page (devtools_app/lib/src/flutter/connect_screen.dart), there should be some validation on the input URL, if I for instance enter random text inserted into connect box in the Connect box where a URL goes, an attempt is made and I see the popup:

Unable to connect to 'random text insterted into connect box'

jwren avatar Feb 07 '20 18:02 jwren

We have this feature in the flutter version of Devtools already: Screen Shot 2020-02-07 at 1 04 29 PM

kenzieschmoll avatar Feb 07 '20 21:02 kenzieschmoll

Talked to Jaime offline - we show a different message if the connection is unavailable "Unable to connect...", so we have the logic to distinguish between a failed connection and an invalid link.

Instead of allowing the connect button to be clicked anyway when the link is not valid, we should disable the connect button and make the outline of the text field red.

kenzieschmoll avatar Feb 07 '20 21:02 kenzieschmoll