flutter_form_builder icon indicating copy to clipboard operation
flutter_form_builder copied to clipboard

Published 20 hours ago • verified publisher icon flutter-form-builder-ecosystem

feat: Perform focus and scroll when invalidated based on autoFocusOnValidationFailure and shouldScrollToInvalidField

Open pongloongyeat opened this issue 3 years ago • 5 comments
trafficstars

Closes #955.

Adds an additional field shouldScrollToInvalidField which defaults to false. On master, this is essentially this PR with shouldScrollToInvalidField set to true. However, due to issues such as #955, I've set it to default to true.

pongloongyeat avatar Jun 27 '22 08:06 pongloongyeat

Can be add tests please?

deandreamatias avatar Jun 27 '22 09:06 deandreamatias

Can be add tests please?

Sure. Will do it over the weekend.

pongloongyeat avatar Jun 28 '22 03:06 pongloongyeat

Nice! Thanks a lot @pongloongyeat for your contribution 🚀

deandreamatias avatar Jun 28 '22 05:06 deandreamatias

Getting a little lost on writing tests to detect for scrolling. Could anyone point me in the right direction?

pongloongyeat avatar Jul 04 '22 03:07 pongloongyeat

Getting a little lost on writing tests to detect for scrolling. Could anyone point me in the right direction?

Hi @pongloongyeat, Has some methods to tests scroll with widgets. Take a look to this and related

deandreamatias avatar Jul 04 '22 05:07 deandreamatias