Usage of luaL_checkint

Open srinarasi opened this issue 4 years ago • 2 comments

I was wondering why the deprecated luaL_checkint is being used instead of luaL_checkinteger. I see that it also made the fix in #30 necessary. Could we not just replace it with luaL_checkinteger which is already being in the code?

Cheers, Bhargava Srinarasi

Jun 21 '21 12:06 srinarasi

no particular reason? probably because it's not deprecated on 5.1 or 5.2, so it just wasn't even noticed that this was another option? Looking now, it looks like only one place in the code that uses checkint anyway, so it could probably be turned to checkinteger and teh rockspec define removed? I don't have time to test that on 5.1, 5.2 and 5.3 (and 5.4?) right now personally though.

Jun 21 '21 17:06 karlp

Thanks for the response. I hope I didn't come across as rude. I have made the change to luaL_checkinteger in my code and at least on Lua v5.3, it works fine.

Jun 21 '21 19:06 srinarasi