walletbeat
walletbeat copied to clipboard
Feat: Signature intent verification maykelxyz
Fixes #213 Continuation of #222
- A lot of changes has been made into
beta. I figured it would be less time consuming to create a new branch, import and adjust Patrick's changes. Doing this made me understand the intent behind the PR and issue as well.
Bikeshedding names is always easy, but here goes:
- I think "dApp Connection Support" should be renamed to "Web3 app support"
- "Signing Intent Clarity" should be renamed "Clear signing", or maybe "Transaction legibility", or just "Signing clarity"
No strong opinion though, I think the current names are fine too. You should ask @PatrickAlphaC for ideas too as he probably has better opinions on the naming here, since he has talked about this problem for much longer than I have.