Update MetaMask Entry
Previous entry seemed to be a hastily cloned Mathwallet entry.
Quite a few of our more recent features were missed:
- Transaction scanning
- Our snaps extensibility system (which enables custom chains, name resolvers, and account backup systems including MPC)
Some of our very long term features were mis-represented:
- Mobile's in-app browser and provider injection.
We may have to come back and update some ENS entries again.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| walletbeat | ❌ Failed (Inspect) | Nov 26, 2024 5:31pm |
I can't see why Vercel failed. Opening for review since I got a sign-off from another member of my team.
This PR is editing src/data/wallets/mathwallet.ts. Did you mean to edit src/data/wallets/metamask.ts? (The current contents of src/data/wallets/metamask.ts are also out-of-date, but they're not the same as mathwallet.ts.)
I can't see why Vercel failed.
I can't see it either, but my guess is because src/data.ts imports mathwallet from ./wallets/mathwallet, and that this PR breaks this import.
hi @danfinlay - thanks for your contribution!
as pointed out by @polymutex you modified the MathWallet file - no need to change this on your end, I can move it to the correct file once the below is clarified
I have a few questions regarding your modifications, I've added them directly on the data below (// means this line was modified vs the version that is live currently):
import { type Info } from '@/types/Info';
export const metamask: Info = {
url: 'https://metamask.io/',
submittedByName: '@danfinlay', //
submittedByUrl: 'https://github.com/danfinlay', //
updatedAt: '11/26/2024', //
updatedByName: '@danfinlay', //
updatedByUrl: 'https://github.com/danfinlay', //
mobile: {
accountType: 'EOA',
chainCompatibility: {
configurable: true,
autoswitch: true, //
ethereum: true,
optimism: true,
arbitrum: true,
base: true, //
polygon: true,
gnosis: true, //
bnbSmartChain: true,
avalanche: true,
},
ensCompatibility: {
mainnet: true,
subDomains: true,
offchain: false,
L2s: false,
customDomains: false,
freeUsernames: false,
},
backupOptions: {
cloud: false,
local: true,
socialRecovery: false,
},
securityFeatures: {
multisig: false,
MPC: false,
keyRotation: false,
transactionScanning: false, // so transactions aren't simulated on mobile?
limitsAndTimelocks: false,
hardwareWalletSupport: true,
},
availableTestnets: {
availableTestnets: true,
},
license: 'OPEN_SOURCE', // according to the license on the mobile GitHub this should be SOURCE_AVAILABLE: https://github.com/MetaMask/metamask-mobile/blob/main/LICENSE
connectionMethods: {
walletConnect: true,
injected: true, //
embedded: false,
inappBrowser: true,
},
modularity: {
modularity: false,
},
},
browser: {
accountType: 'EOA',
chainCompatibility: {
configurable: true,
autoswitch: true,
ethereum: true,
optimism: true,
arbitrum: true,
base: true,
polygon: true,
gnosis: true,
bnbSmartChain: true,
avalanche: true,
},
ensCompatibility: {
mainnet: true,
subDomains: true,
offchain: false, // should be true, MetaMask supports offchain ENS resolution - I tested this recently
L2s: true,
customDomains: false,
freeUsernames: false,
},
backupOptions: {
cloud: false,
local: true,
socialRecovery: false,
},
securityFeatures: {
multisig: false,
MPC: true, // can you confirm MetaMask supports MPC keys?
keyRotation: false,
transactionScanning: true,
limitsAndTimelocks: false,
hardwareWalletSupport: true,
},
availableTestnets: {
availableTestnets: true,
},
license: 'OPEN_SOURCE', // I don't think the license on the extension GitHub fits with OSI standards: https://github.com/MetaMask/metamask-extension/blob/develop/LICENSE
connectionMethods: {
walletConnect: true, // does WalletConnect work on the extension?
injected: true,
embedded: false,
inappBrowser: false,
},
modularity: {
modularity: true,
},
},
};