feat: added dapp connection support for hardware wallets, and signing…

[PatrickAlphaC]

This ended up being a bigger change, because as I dug deeper, more unearthed.

• It made sense to me to separate signingIntentClarity from a new attribute of dappConnectionSupport specifically for hardware wallets (we have a feature of what HW wallets a software wallet supports, why not the other way around?)
• Adding signingIntentClarity to all wallets I think is important, with the feature rating being only what calldata/transaction data is being shown on the device itself (for example, if ledger live showed TX data, but not the device, we would mark that the ledger device does not show TX data)
• I added an image of coinbase wallet failing to show calldata/tx data, I wasn't sure where to put it as a reference
• softened the calldata decoding requirements if a wallet allows the user to extract that calldata
• it probably makes sense to put the dappConnectionSupport into the ecosystem bucket over security

Let me know what you think

Fixes: https://github.com/walletbeat/walletbeat/issues/213#event-18478799408

[polymutex]

This ended up being a bigger change, because as I dug deeper, more unearthed.

Sorry for the deluge of comments as a result :)

• It made sense to me to separate signingIntentClarity from a new attribute of dappConnectionSupport specifically for hardware wallets (we have a feature of what HW wallets a software wallet supports, why not the other way around?)

For sure.

• Adding signingIntentClarity to all wallets I think is important, with the feature rating being only what calldata/transaction data is being shown on the device itself (for example, if ledger live showed TX data, but not the device, we would mark that the ledger device does not show TX data)

Agreed.

• softened the calldata decoding requirements if a wallet allows the user to extract that calldata

Makes sense.

• it probably makes sense to put the dappConnectionSupport into the ecosystem bucket over security

Seems right, since it doesn't affect security and it's more about ecosystem integration.

[PatrickAlphaC]

The comments are great!

Doing the reviews showed me that there are some issues with the current attributes group. https://github.com/walletbeat/walletbeat/issues/223

[PatrickAlphaC]

Ok! We've moved the dapp support to the ecosystem column

But it made me think the way we currently are organizing might need a hand: https://github.com/walletbeat/walletbeat/issues/224

https://github.com/walletbeat/walletbeat/issues/223

And signing intent clarity is now live for both software and hardware wallets!

[maykelxyz]

Continuation here #352