fluidd icon indicating copy to clipboard operation
fluidd copied to clipboard

feat: quick button "switch light"

Open dizz74 opened this issue 3 years ago • 2 comments

Quick button "light" in the top navigation. Need select light's pin in settings. Screenshot_32

dizz74 avatar Sep 13 '22 04:09 dizz74

I have to admit I am struggling a bit with this one! Functionally, it is working fine and does exactly what it says, but seems a bit weird that for the Power button we are listing the Moonraker entities and there we are showing the Pins directly...

Personally, I think I would prefer for both to use the Moonraker power entities and allow users to configure them there (so this functionality would mimic the one of the existing power button)

pedrolamas avatar Sep 22 '22 11:09 pedrolamas

Consistency is king but this seems way more straight forward to set up than what the Moonraker docs show. I probably would not even bother if I had to set it up according to moonraker lmao. https://moonraker.readthedocs.io/en/latest/configuration/#power

The chamber lights have to be hands down the most used macro so I am very much looking forward to this.

ChaosBlades avatar Oct 05 '22 10:10 ChaosBlades

@dizz74 FYI, I've merged the changes from this PR #970 so that it has a single toggle on the appbar, and users can pick between a Moonraker Power Device or a Klipper Output Pin.

pedrolamas avatar Dec 06 '22 12:12 pedrolamas

Implemented via #970

pedrolamas avatar Dec 07 '22 09:12 pedrolamas