fluidd icon indicating copy to clipboard operation
fluidd copied to clipboard

feat: Moonraker Job Queue Support

Open bwnance opened this issue 4 years ago • 9 comments

Added support for Moonraker's job queue system (https://moonraker.readthedocs.io/en/latest/web_api/#job-queue-apis)

Signed-off-by: Brandon Nance [email protected]

bwnance avatar Nov 18 '21 08:11 bwnance

@bwnance Hey, just checking in, any updates on this or feedback to my comment? Thanks!

matmen avatar Mar 23 '22 19:03 matmen

@matmen ah! Sorry, never saw the notification for your comments. I'll take a look, thank you!

bwnance avatar Mar 23 '22 19:03 bwnance

@matmen I'm totally fine to remove that extra page and only have it in the dashboard. I thought it made sense to duplicate data in the dash to pages, but with the minimal amount of extra info, I think it's fine. Especially since we can queue files from the context menu.

bwnance avatar Mar 23 '22 19:03 bwnance

@matmen ok so i'll remove the Queue page. is it ok to leave it in but disabled? it's feasible that there will be some functionality added later that would warrant a dedicated queue page, and would save someone in the future the work

bwnance avatar Mar 23 '22 20:03 bwnance

Not sure about leaving unreferenced files in the codebase, considering they are always stored in Git. Will need to see what Pedro's opinion on this is. I can't seem to disable the queue card in the layout view (the checkbox is there, but unchecking it does nothing), and there's no way to collapse the card.

matmen avatar Mar 23 '22 20:03 matmen

@matmen ah sorry. didn't test in-depth enough. will resolve that. and yeah, up to @pedrolamas on leaving those files in. I have no problem deleting if it's an issue

bwnance avatar Mar 23 '22 21:03 bwnance

@matmen resolved in f353aae

bwnance avatar Mar 23 '22 21:03 bwnance

@matmen ah sorry. didn't test in-depth enough. will resolve that. and yeah, up to @pedrolamas on leaving those files in. I have no problem deleting if it's an issue

Ideally, I prefer not to leave dead (unused) code in the repository (that's what I use separate branches for! 😁)

pedrolamas avatar Mar 27 '22 17:03 pedrolamas

@matmen ah sorry. didn't test in-depth enough. will resolve that. and yeah, up to @pedrolamas on leaving those files in. I have no problem deleting if it's an issue

Ideally, I prefer not to leave dead (unused) code in the repository (that's what I use separate branches for! 😁)

Ok! Will remove dead code

bwnance avatar Mar 28 '22 19:03 bwnance

I've been refactoring and updating this code, in the hope to get it merged on the v1.23 release!

Edit: I'll keep the initial post screenshots updated with current status!

pedrolamas avatar Dec 12 '22 17:12 pedrolamas

@pedrolamas thank you so much for taking this one over!! I haven't had much time to work on it, and the use-case i had for it is no longer with me, haha.

bwnance avatar Dec 12 '22 18:12 bwnance

No worries, to be honest I don't think I have a personal use either, but I see a lot of value in your work for those who do actually use the Job Queue, so I want to make sure we can get this merged and released ASAP!

pedrolamas avatar Dec 12 '22 18:12 pedrolamas

Merry Christmas everyone!! 🎅

I now consider this work complete and ready for PR review! 😁

pedrolamas avatar Dec 24 '22 15:12 pedrolamas

@pedrolamas Thanks for making queue available on fluidd, I'm working on a belt printer project, is there a way to set "resume" print automatically?, since the belt printer will release parts, we will need to automatically start the new print after part is released, idea is not to babysit the printer nor press resume button in order to start new print, thanks in advance for your reply.

andresandia avatar Jan 27 '23 04:01 andresandia

@andresandia you should only need to click "resume" once, to start the first print. After that, it will carry on picking items from the queue to print!

You also need to make sure your [job_queue] section on moonraker.conf has automatic_transition: true

Docs here: https://moonraker.readthedocs.io/en/latest/configuration/#job_queue

pedrolamas avatar Jan 27 '23 09:01 pedrolamas