makes
makes copied to clipboard
fluidattacks
modules still contain job definitions
❯ rg -Nol makeTemplate src/evaluator
❯ rg -Nol makeScript src/evaluator
src/evaluator/modules/format-python/default.nix
src/evaluator/modules/format-nix/default.nix
src/evaluator/modules/format-markdown/default.nix
src/evaluator/modules/hello-world/default.nix
src/evaluator/modules/pipelines/default.nix
❯ rg -Nol makeDerivation src/evaluator
src/evaluator/modules/lint-bash/default.nix
src/evaluator/modules/lint-python/default.nix
src/evaluator/modules/lint-nix/default.nix
# cross check
❯ fd --extension sh . src/evaluator
src/evaluator/modules/format-markdown/entrypoint.sh
src/evaluator/modules/format-nix/entrypoint.sh
src/evaluator/modules/format-python/entrypoint.sh
src/evaluator/modules/lint-bash/builder.sh
src/evaluator/modules/lint-nix/builder.sh
src/evaluator/modules/pipelines/entrypoint-for-job.sh
src/evaluator/modules/pipelines/entrypoint-for-pipeline-on-gitlab.sh
src/evaluator/modules/pipelines/entrypoint-for-pipeline.sh
→ Most of them should probably be implemented as (agnostic) args?
It occurred to me since I intuitively wouldn't have expected to find proper job definitions inside the module system (but rather only see making use of existing ones).
Not 100% sure about this.
This is something we are pending to migrate, this separation of concerns was only added after a few iterations so the modules we wrote first have both the interface and the implementation in the same module file
