makes
makes copied to clipboard
enforce camelCase outputs
depending on how you name folders on the makes/ folder, the outputs are going to look like-this, or likeThis, or whatever you name the directories.
for consistency with makes built-ins, we should translate directory names to camelCase: https://levelup.gitconnected.com/converting-a-string-to-camelcase-in-javascript-f88a646a22b4
so people can have directories like /makes/my-derivation/main.nix, but execute m .myDerivation
nix has no built-in, and nixpkgs does not have a function in lib.strings, so we should create our own in this function: https://github.com/fluidattacks/makes/blob/27b669a539c6be8caffbbfab23da07a8c87a1f13/src/modules/outputs/custom.nix#L16 (turn name into camelCase before appending to the list)
example of the casing incoherence:
@kamadorueda I am interested in working on this issue. Can I work on it?
@kamadorueda I am interested in working on this issue. Can I work on it?
@dsalaza4 is the current maintainer
Hi, @dsalaza4! Can I work on this issue?
@0xt3j4s Sure! If you have any questions do not hesitate to ask!
This is the relevant source code:
https://github.com/fluidattacks/makes/blob/main/src/evaluator/modules/default.nix#L91
Thank you, @dsalaza4! I'll start working on this issue and make a PR soon.
Hey @dsalaza4, in the description of the issue, it is given that I need to change the name to camelCase in this file.
While you had given a different source code that is quite similar to the one shown in the issue, though in a another directory.
Can you confirm the name conversion to camelCase should be done in which directory or branch?
@0xt3j4s As this issue was created years ago, the source code has changed significantly. The file mentioned initially no longer exists.
Oh, Ok. I got it and will work accordingly.