fluid icon indicating copy to clipboard operation
fluid copied to clipboard

This PR is to add comments to TestTransformResourcesForMaster in pkg/ddc/alluxio/transform_resources_test.go.

Open WUPEIhello opened this issue 6 months ago • 4 comments

Ⅰ. Describe what this PR does
Add comments to the TestTransformResourcesForMaster function in pkg/ddc/alluxio/transform_resources_test.go for better code readability and maintenance.

Ⅱ. Does this pull request fix one issue?
fixes #5129

Ⅲ. Special notes for reviews
fixes

WUPEIhello avatar Jun 18 '25 10:06 WUPEIhello

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign ronggu for approval by writing /assign @ronggu in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

fluid-e2e-bot[bot] avatar Jun 18 '25 10:06 fluid-e2e-bot[bot]

Hi @WUPEIhello. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fluid-e2e-bot[bot] avatar Jun 18 '25 10:06 fluid-e2e-bot[bot]

/ok-to-test

cheyang avatar Jun 21 '25 06:06 cheyang