fluid icon indicating copy to clipboard operation
fluid copied to clipboard

This PR is to add comments to generateGooseFSValueFile in pkg\ddc\goosefs\master_internal.go

Open biluohq opened this issue 7 months ago • 3 comments

Ⅰ. Describe what this PR does

add comments to generateGooseFSValueFile in pkg\ddc\goosefs\master_internal.go

Ⅱ. Does this pull request fix one issue?

fixes #5112

Ⅲ. Special notes for reviews

nothing

biluohq avatar Jun 14 '25 22:06 biluohq

Hi @biluohq. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fluid-e2e-bot[bot] avatar Jun 14 '25 22:06 fluid-e2e-bot[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 55.51%. Comparing base (48e7fb5) to head (96e3b04). :warning: Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5113      +/-   ##
==========================================
- Coverage   55.52%   55.51%   -0.01%     
==========================================
  Files         443      443              
  Lines       30382    30382              
==========================================
- Hits        16870    16867       -3     
- Misses      11960    11962       +2     
- Partials     1552     1553       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 12 '25 08:09 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

fluid-e2e-bot[bot] avatar Sep 12 '25 10:09 fluid-e2e-bot[bot]