fluid icon indicating copy to clipboard operation
fluid copied to clipboard

This pr is to add license to ./pkg/common/constants.go

Open melldy opened this issue 9 months ago • 3 comments

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

melldy avatar May 08 '24 02:05 melldy

Hi @melldy. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fluid-e2e-bot[bot] avatar May 08 '24 02:05 fluid-e2e-bot[bot]

/assign @cheyang thanks

melldy avatar May 16 '24 12:05 melldy

@melldy: GitHub didn't allow me to assign the following users: thanks.

Note that only fluid-cloudnative members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @cheyang thanks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fluid-e2e-bot[bot] avatar May 16 '24 12:05 fluid-e2e-bot[bot]

/lgtm

LiYuhang9527 avatar May 21 '24 08:05 LiYuhang9527

@LiYuhang9527: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fluid-e2e-bot[bot] avatar May 21 '24 08:05 fluid-e2e-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

fluid-e2e-bot[bot] avatar May 30 '24 11:05 fluid-e2e-bot[bot]