fluid icon indicating copy to clipboard operation
fluid copied to clipboard

Feature: support dynamic mount for ossfs

Open wangshli opened this issue 2 years ago • 5 comments

Ⅰ. Describe what this PR does

support dynamic mount for ossfs by thinruntime plugin

  • support csi plugin use symlink by add annotation in runtime, such as below:
    • data.fluid.io/metadataList: "[{"Labels": {"fluid.io/node-puhlish-method": "symlink"}, "selector": { "kind": "PersistentVolume"}}]"
  • thinruntime controller adds watch to dataset
  • support thinruntime fuse-config update in use

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

  • create dataset with thinruntime use ossfs-profile thinruntime profile
  • create app pod to mount above dataset
  • modify dataset mounts
  • see the corresponding changes in the app pod

Ⅴ. Special notes for reviews

Compatibility: change thinruntime fuse pod configmap mount location from /etc/fluid/config.json to /etc/fluid/config/config.json

wangshli avatar Sep 01 '23 09:09 wangshli

Hi @wangshli. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fluid-e2e-bot[bot] avatar Sep 01 '23 09:09 fluid-e2e-bot[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 04 '23 08:09 sonarqubecloud[bot]

Codecov Report

Attention: Patch coverage is 25.89286% with 83 lines in your changes are missing coverage. Please review.

Project coverage is 64.18%. Comparing base (6d0ba26) to head (a91023d). Report is 37 commits behind head on master.

:exclamation: Current head a91023d differs from pull request most recent head 1c5841d. Consider uploading reports for the commit 1c5841d to get more accurate results

Files Patch % Lines
pkg/ddc/thin/ufs.go 29.85% 43 Missing and 4 partials :warning:
pkg/ctrl/watch/dataset.go 0.00% 19 Missing :warning:
pkg/ctrl/watch/manager.go 0.00% 14 Missing :warning:
pkg/ddc/thin/operations/base.go 50.00% 1 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3432      +/-   ##
==========================================
- Coverage   64.33%   64.18%   -0.15%     
==========================================
  Files         477      478       +1     
  Lines       28444    28547     +103     
==========================================
+ Hits        18300    18324      +24     
- Misses       7968     8043      +75     
- Partials     2176     2180       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 08 '23 02:10 codecov[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 31 '23 11:10 sonarqubecloud[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [TrafalgarZZZ,cheyang]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

fluid-e2e-bot[bot] avatar May 09 '24 12:05 fluid-e2e-bot[bot]