fluid icon indicating copy to clipboard operation
fluid copied to clipboard

feat: re-setup master when master role restarted or recreated and recover dataset

Open SimonCqk opened this issue 1 year ago • 8 comments

Ⅰ. Describe what this PR does

fix #3368

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

see /pkg/ctrl/master_test.go

Ⅳ. Describe how to verify it

  1. apply a brand new JindoFS cache cluster and wait all pods ready
  2. delete jindo master pod and wait it running
  3. exec into jindo master and execute jindo admin -mount, check oss mountpoint has been re-mounted or not from stdout.

Ⅴ. Special notes for reviews

SimonCqk avatar Aug 07 '23 13:08 SimonCqk

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign ronggu for approval by writing /assign @ronggu in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

fluid-e2e-bot[bot] avatar Aug 07 '23 13:08 fluid-e2e-bot[bot]

Hi @SimonCqk. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fluid-e2e-bot[bot] avatar Aug 07 '23 13:08 fluid-e2e-bot[bot]

I think we can do this during entrypoint startup, when master pod recreate or transfer to other node, we can use entrypoint script to recover mount point

frankleaf avatar Aug 08 '23 06:08 frankleaf

@SimonCqk please fix the source code check, thanks.

cheyang avatar Aug 18 '23 06:08 cheyang

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
9.8% 9.8% Duplication

sonarqubecloud[bot] avatar Aug 29 '23 02:08 sonarqubecloud[bot]

@SimonCqk please fix the source code check, thanks.

done :)

SimonCqk avatar Aug 29 '23 07:08 SimonCqk