fluid icon indicating copy to clipboard operation
fluid copied to clipboard

Merge pull request #1 from fluid-cloudnative/master

Open Gargameldtburp opened this issue 2 years ago • 5 comments

This pr is to add Copyright of /pkg/common/fluid_ufs_scheme.go

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Gargameldtburp avatar Jul 12 '23 09:07 Gargameldtburp

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

fluid-e2e-bot[bot] avatar Jul 12 '23 09:07 fluid-e2e-bot[bot]

Hi @Gargameldtburp. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fluid-e2e-bot[bot] avatar Jul 12 '23 09:07 fluid-e2e-bot[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jul 12 '23 10:07 sonarqubecloud[bot]

Codecov Report

Merging #3337 (ad2c6ef) into master (284e7ee) will increase coverage by 0.00%. The diff coverage is 63.73%.

:exclamation: Current head ad2c6ef differs from pull request most recent head 9c6a7d3. Consider uploading reports for the commit 9c6a7d3 to get more accurate results

@@           Coverage Diff            @@
##           master    #3337    +/-   ##
========================================
  Coverage   65.45%   65.45%            
========================================
  Files         396      402     +6     
  Lines       23052    23256   +204     
========================================
+ Hits        15088    15223   +135     
- Misses       6179     6253    +74     
+ Partials     1785     1780     -5     
Impacted Files Coverage Δ
api/v1alpha1/alluxioruntime_types.go 33.33% <ø> (ø)
api/v1alpha1/common.go 0.00% <ø> (ø)
api/v1alpha1/dataload_types.go 100.00% <ø> (ø)
api/v1alpha1/datamigrate_types.go 100.00% <ø> (ø)
api/v1alpha1/efcruntime_types.go 11.11% <ø> (ø)
api/v1alpha1/goosefsruntime_types.go 33.33% <ø> (ø)
api/v1alpha1/jindoruntime_types.go 33.33% <ø> (ø)
api/v1alpha1/juicefsruntime_types.go 33.33% <ø> (ø)
api/v1alpha1/thinruntime_types.go 33.33% <ø> (ø)
pkg/common/constants.go 100.00% <ø> (ø)
... and 54 more

... and 7 files with indirect coverage changes

codecov[bot] avatar Jul 12 '23 12:07 codecov[bot]

@Gargameldtburp please check your changes. I am not able to see any file changes in your PR.

cheyang avatar Jul 14 '23 00:07 cheyang