Feat: support preloading data during the init phase
Ⅰ. Describe what this PR does
The design documents: https://docs.google.com/document/d/1aP0mP_66Jmx05Vlcswa3D5e7hsfHdQGygsFERFttz68/edit?usp=sharing
Ⅱ. Does this pull request fix one issue?
fixes #3181
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Add testcase for init container which use the dataset PVC
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
- For each pod, check and override the init containers volumemounts which use dataset to emprtyDir volume;
- For each dataset PVC in this pod:
-
- Add emptyDir to the pod's volumes
-
- Change fuse template for init container
-
- Inject the fuse container to init phase
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign trafalgarzzz for approval by writing /assign @trafalgarzzz in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @wang-mask. Thanks for your PR.
I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/retitle Feat: support preloading data during the init phase
Codecov Report
Merging #3211 (eccc447) into master (d720130) will increase coverage by
0.03%. The diff coverage is63.24%.
:exclamation: Current head eccc447 differs from pull request most recent head 6b7211c. Consider uploading reports for the commit 6b7211c to get more accurate results
@@ Coverage Diff @@
## master #3211 +/- ##
==========================================
+ Coverage 65.45% 65.48% +0.03%
==========================================
Files 396 399 +3
Lines 23052 23362 +310
==========================================
+ Hits 15088 15299 +211
- Misses 6179 6258 +79
- Partials 1785 1805 +20
| Impacted Files | Coverage Δ | |
|---|---|---|
| api/v1alpha1/alluxioruntime_types.go | 33.33% <ø> (ø) |
|
| api/v1alpha1/datamigrate_types.go | 100.00% <ø> (ø) |
|
| api/v1alpha1/efcruntime_types.go | 11.11% <ø> (ø) |
|
| api/v1alpha1/goosefsruntime_types.go | 33.33% <ø> (ø) |
|
| api/v1alpha1/jindoruntime_types.go | 33.33% <ø> (ø) |
|
| api/v1alpha1/juicefsruntime_types.go | 33.33% <ø> (ø) |
|
| api/v1alpha1/thinruntime_types.go | 33.33% <ø> (ø) |
|
| pkg/common/constants.go | 100.00% <ø> (ø) |
|
| pkg/common/init.go | 100.00% <ø> (ø) |
|
| pkg/common/label.go | 74.28% <ø> (ø) |
|
| ... and 40 more |
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
13 Code Smells
No Coverage information
29.4% Duplication
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
13 Code Smells
No Coverage information
29.1% Duplication