fluid icon indicating copy to clipboard operation
fluid copied to clipboard

update to golang1.18.10 in eacruntime and webhook

Open wangshli opened this issue 2 years ago • 9 comments

Ⅰ. Describe what this PR does

update image to golang1.18.10 in eacruntime and webhook

Ⅱ. Does this pull request fix one issue?

fixes #2830

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

wangshli avatar Apr 03 '23 06:04 wangshli

Hi @wangshli. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fluid-e2e-bot[bot] avatar Apr 03 '23 06:04 fluid-e2e-bot[bot]

Codecov Report

Merging #2867 (043e956) into master (d3de533) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 043e956 differs from pull request most recent head 47d0a85. Consider uploading reports for the commit 47d0a85 to get more accurate results

@@           Coverage Diff           @@
##           master    #2867   +/-   ##
=======================================
  Coverage   65.58%   65.58%           
=======================================
  Files         396      396           
  Lines       22798    22798           
=======================================
  Hits        14951    14951           
  Misses       6098     6098           
  Partials     1749     1749           
Impacted Files Coverage Δ
pkg/ddc/alluxio/cache.go 75.67% <ø> (ø)
pkg/ddc/alluxio/dataset.go 69.33% <ø> (ø)
pkg/ddc/alluxio/label.go 100.00% <ø> (ø)
pkg/ddc/alluxio/shutdown.go 46.39% <ø> (ø)
pkg/ddc/alluxio/transform_init_users.go 100.00% <ø> (ø)
pkg/ddc/alluxio/transform_ufs.go 100.00% <ø> (ø)
pkg/ddc/alluxio/types.go 100.00% <ø> (ø)
pkg/ddc/alluxio/ufs.go 43.75% <ø> (ø)
pkg/ddc/goosefs/cache.go 69.23% <ø> (ø)
pkg/ddc/goosefs/worker.go 73.77% <ø> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Apr 03 '23 06:04 codecov[bot]

/test fluid-e2e

cheyang avatar Apr 06 '23 08:04 cheyang

@cheyang: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test fluid-e2e
  • /test fluid-e2e-080
  • /test fluid-e2e-nightly

In response to this:

/test fluid-e2e-night

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fluid-e2e-bot[bot] avatar Apr 06 '23 08:04 fluid-e2e-bot[bot]

/test fluid-e2e-nightly

cheyang avatar Apr 06 '23 08:04 cheyang

@wangshli Could you also update other related docker file? I think we'd better keep consistency.

cheyang avatar Apr 07 '23 02:04 cheyang

@wangshli Could you also update other related docker file? I think we'd better keep consistency.

For all dockerfile with builder golang 1.18 ?

wangshli avatar Apr 07 '23 02:04 wangshli

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign yangyuliufeng for approval by writing /assign @yangyuliufeng in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

fluid-e2e-bot[bot] avatar Apr 07 '23 11:04 fluid-e2e-bot[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 10 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 07 '23 11:04 sonarqubecloud[bot]