fluid icon indicating copy to clipboard operation
fluid copied to clipboard

[FEATURES]Support Running in Apple M1

Open swartz-k opened this issue 3 years ago • 2 comments

What feature you'd like to add: ENV: Apple M1 While running below code,

 make test

will meet errors as below

....
# github.com/agiledragon/gomonkey
../../../../pkg/mod/github.com/agiledragon/[email protected]+incompatible/patch.go:163:10: undefined: buildJmpDirective
make: *** [vet] Error 1

Ref gomonkey issue 38

Some changes needed

--- a/go.mod
+++ b/go.mod
@@ -1,9 +1,9 @@
 
 require (
-       github.com/agiledragon/gomonkey v2.0.2+incompatible
+       github.com/agiledragon/gomonkey/v2 v2.2.0

--- a/pkg/ddc/alluxio/cache_test.go
+++ b/pkg/ddc/alluxio/cache_test.go
@@ -4,7 +4,7 @@ import (
        "reflect"
        "testing"
 
-       . "github.com/agiledragon/gomonkey"
+       . "github.com/agiledragon/gomonkey/v2"

Why is this feature needed: I am not sure if this needed. :-)

swartz-k avatar Sep 18 '21 10:09 swartz-k

Thanks for opening it. @swartz-k , if you'd like open an PR on fixing it, we will be very appreciated.

cheyang avatar Sep 23 '21 01:09 cheyang

Thanks for opening it. @swartz-k , if you'd like open an PR on fixing it, we will be very appreciated.

Sure, I will do that. And also should we upgrade go version and newer k8s lib maybe v0.18.x -> v0.2x.x

swartz-k avatar Sep 23 '21 02:09 swartz-k