helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Add CODEOWNERS file to the repo

Open marcofranssen opened this issue 6 months ago • 3 comments

Using a CODEOWNERS file PRs get automatically assigned reviewers.

# These owners will be the default owners for everything in
# the repo. Unless a later match takes precedence,
# they will be requested for review when someone opens a
# pull request.
*                                             @user-a @user-b
charts/fluent-operator/*               @marcofranssen @joshuabaird @benjaminhuo @cw-Guo

# See CODEOWNERS syntax here: https://help.github.com/articles/about-codeowners/#codeowners-syntax

Using branch protections it can also be configured that PRs need to be approved by a CODEOWNER.

For the fluent-operator chart I have already listed the maintainters.

@benjaminhuo did I miss anyone?

marcofranssen avatar May 09 '25 11:05 marcofranssen

I think we need to make sure the default codeowners are correct as they control everything else (including the codeowners), not just insert only for the operator.

Branch protection is deprecated now as well, it should be via rulesets.

patrick-stephens avatar May 15 '25 12:05 patrick-stephens

@patrick-stephens in those rulesets you can also configure PRs need to be reviewed by CODEOWNERS.

marcofranssen avatar May 16 '25 10:05 marcofranssen

@patrick-stephens in those rulesets you can also configure PRs need to be reviewed by CODEOWNERS.

Yup, my point was to use them rather than the branch protection which will be removed

patrick-stephens avatar May 16 '25 10:05 patrick-stephens