fluent-plugin-sql icon indicating copy to clipboard operation
fluent-plugin-sql copied to clipboard

Missing Copyright and License

Open caraarslan opened this issue 2 years ago • 6 comments

Dear Team,

Your software is missing the copyright (e.g. Copyright 2023 - X Y - x.y@domain) and a License (e.g. MIT - https://opensource.org/license/mit/). This is needed for legal purposes, that your rights and intentions are properly represented. Please add these to your GitHub page.

Many thanks! Have a nice day!

caraarslan avatar Jun 30 '23 08:06 caraarslan

Thanks for your report. Currently, out_sql.rb seems lack of copyright notice. Could y'all take a look on this, @ashie @kenhys @daipom?

cosmo0920 avatar Aug 03 '23 10:08 cosmo0920

It seems that the license is Apache-2.0, and the copyright is written in each program file.

https://github.com/fluent/fluent-plugin-sql/blob/48e3927d27fa6ff53a846f1a95d33b02094888cb/lib/fluent/plugin/in_sql.rb#L1-L17

https://github.com/fluent/fluent-plugin-sql/blob/48e3927d27fa6ff53a846f1a95d33b02094888cb/fluent-plugin-sql.gemspec#L17

daipom avatar Aug 03 '23 10:08 daipom

Should we add the License file and information about Copyright to README?

daipom avatar Aug 03 '23 10:08 daipom

Currently, out_sql.rb seems lack of copyright notice.

Oh, out_sql.rb!

daipom avatar Aug 03 '23 10:08 daipom

How should we add them?

out_sql.rb was originally added by FURUHASHI Sadayuki , but it was removed at 7154ae98d05cf4525a8b49f39fd961d088baed11.

After it, @repeatedly added it again at e5a389d81d63a6d7a8ce910ededa1c8617218803.

daipom avatar Aug 03 '23 10:08 daipom

Hi,

You can have a look at other ruby gems, e.g. FluentD. https://github.com/fluent/fluentd Usually they have a license.txt file and the copyright is either captured in the license or at the following places: notice.txt or in the readme file. At each release you need to check whether the copyright needs to be updated. You can go also with a different License than Apache 2.0. Beside Apache 2.0 the MIT license is also very common. You can check out the open source licenses at: https://opensource.org/licenses/

Cheers, cara_arslan

caraarslan avatar Aug 03 '23 11:08 caraarslan