fluent-plugin-kafka icon indicating copy to clipboard operation
fluent-plugin-kafka copied to clipboard

feat(out_waterdrop): add basic waterdrop output plugin

Open raytung opened this issue 1 year ago • 3 comments
trafficstars

This is a super simple proof-of-concept implementation for Waterdrop as described in https://github.com/fluent/fluent-plugin-kafka/issues/500. We'll need a lot more work to get this up to scratch compared to the other output plugins but I don't want to make this PR even larger :smile:

raytung avatar Apr 01 '24 04:04 raytung

This PR has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this PR will be closed in 30 days

github-actions[bot] avatar Jul 30 '24 10:07 github-actions[bot]

This couldn't be included in v0.19.3 release. But can we mark as v0.20.0.rc milestone? This is because we have to seek successor of pure Ruby client for Kafka.

cosmo0920 avatar Aug 01 '24 04:08 cosmo0920

IMHO there is no problem merging this in any timing for make it as prototype of the new plugin and improve it step by step if we remove gem.add_dependency 'waterdrop', '~> 2.6'. Merging PoC code for new feature but disable by default is a common practice in large OSS projects such as Chromium or Firefox.

ashie avatar Aug 02 '24 05:08 ashie