fluent-operator icon indicating copy to clipboard operation
fluent-operator copied to clipboard

Changed the kafka_types.go file and introduced a mapvalue struct.

Open TheJadeLion2004 opened this issue 1 year ago • 2 comments

In kvs.go, introduced an InsertValueMap function and a SecretProvider interface.

What this PR does / why we need it:

The PR attempts to change the type of the Kafka struct from a dictionary of strings to a dictionary of variant type, where the variant contains either a string or a *plugins.Secret. Needed to also change the InsertStringValueMap function and replace it by an insert MapValueMap function which does whatever the original function does, but now, tries to add elements to the map of the variant type.

An interface was used to avoid circular dependency, however there is some deepcopy error that is being generated.

Which issue(s) this PR fixes:

Fixes # https://github.com/fluent/fluent-operator/issues/1152

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


TheJadeLion2004 avatar Sep 02 '24 09:09 TheJadeLion2004

I've created a pull request in order to check the base logic, and to get help in verifying errors. This is NOT a working PR.

TheJadeLion2004 avatar Sep 02 '24 09:09 TheJadeLion2004

I've created a pull request in order to check the base logic, and to get help in verifying errors. This is NOT a working PR. CI errors https://github.com/fluent/fluent-operator/actions/runs/10664149221/job/29556121218?pr=1328#step:7:46

benjaminhuo avatar Nov 26 '24 02:11 benjaminhuo

Closing due to inactivity. Please re-open if necessary.

joshuabaird avatar Oct 29 '25 14:10 joshuabaird