fluent
parameterized the tagging of tail plugin
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes 1 : Parameterising the tag for tail plugin. Overriding this value will help changing the tags according to the requirements.
@harshvora10101 Thanks for the PR. You'll need to sign your commit by:
git commit -s --amend
git push -f
There are output plugins affected too https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-output-opensearch.yaml#L12
Fluent Operator is used to deploy FluentBit to collect k8s logs, so kube.* is ok. I wonder what's the reason for changing this tag to others.
cc @wanjunlei
@benjaminhuo
With this change, we are not changing the tag (Just making the code generalized). So I doubt that output plugins will be affected.
There are use cases where we need multiple tail plugins for different applications with different tags. So a hardcoded tag is hard to change.
To be precise
There are multiple tail plugins used for kubernetes with xyz.kube.* and abc.kube.* etc.
https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-output-elasticsearch.yaml#L12 Shouldn't this situation be dealt with as well?
@harshvora10101 can you resolve the merge conflicts
$ git checkout master
$ git pull upstream master
$ git checkout parameterization-of-tags
$ git rebase - --signoff
$ git push --force-with-lease
