fluent-operator icon indicating copy to clipboard operation
fluent-operator copied to clipboard

fix: support datadog plugin api key to allow for secret injection

Open nitintecg opened this issue 1 year ago • 3 comments

What this PR does / why we need it:

Modified datadog_types.go file to support datadog plugin api key for allowing the value to take from secret.

Which issue(s) this PR fixes:

Fixes #1060

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


nitintecg avatar Feb 21 '24 20:02 nitintecg

@nitintecg Thanks for this PR. You'll need to run the following to generate code and docs:

make manifests
make generate
make fmt
make vet
make docs-update

benjaminhuo avatar Mar 04 '24 15:03 benjaminhuo

@benjaminhuo I'm getting below error while running make generate and make manifests commands

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference

nitintecg avatar Mar 04 '24 20:03 nitintecg

@benjaminhuo I'm getting below error while running make generate and make manifests commands

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference

@wenchajun @wanjunlei This is an env issue?

benjaminhuo avatar Mar 06 '24 03:03 benjaminhuo

You can check the go and controller_gem version,https://github.com/fluent/fluent-operator/blob/master/Makefile#L149

wenchajun avatar Mar 08 '24 03:03 wenchajun

@wenchajun Thanks, it was go version issue and after installing proper go version it resolved my issue. @benjaminhuo after running commands its generating docs for multine_types.go and rewritetag_types.go. So its expected in this PR or should i exclude docs changes for multiline_types.go and rewritetag_types.go from my PR ?

nitintecg avatar Mar 10 '24 19:03 nitintecg

@benjaminhuo after running commands its generating docs for multine_types.go and rewritetag_types.go. So its expected in this PR or should i exclude docs changes for multiline_types.go and rewritetag_types.go from my PR ?

@nitintecg yeah, it's ok. Someone else forgets to generate docs for their PRs. would you push your new changes?

benjaminhuo avatar Mar 11 '24 01:03 benjaminhuo

@benjaminhuo i have added docs changes in this PR. Can you review ?

nitintecg avatar Mar 28 '24 19:03 nitintecg

@benjaminhuo i have added docs changes in this PR. Can you review ?

@nitintecg thanks a lot for working on this! We're adopting fluent bit and definitely need this capability.

fernandoataoldotcom avatar Mar 28 '24 21:03 fernandoataoldotcom

@nitintecg would you help to resolve the conflicts?

benjaminhuo avatar Apr 06 '24 15:04 benjaminhuo

@benjaminhuo , i tried resolving conflicts and was running commands for generating docs but while running make docs-update its giving below error.

Error while generating documentation: open ./docs/plugins/fluentbit/multilineparser/multilineparser.md: no such file or directory

Can you help me ?

nitintecg avatar Apr 06 '24 21:04 nitintecg

@nitintecg The error you had might have been fixed around the time you had it. Please see: https://github.com/fluent/fluent-operator/issues/1120

venkatamutyala avatar Apr 22 '24 01:04 venkatamutyala

@nitintecg Thank you!

benjaminhuo avatar Apr 23 '24 06:04 benjaminhuo