fluent-operator icon indicating copy to clipboard operation
fluent-operator copied to clipboard

Bump all dependencies to latest to upgrade controller-runtime

Open markusthoemmes opened this issue 1 year ago • 10 comments

What this PR does / why we need it:

This upgrades all dependencies of the project to their latest releases. The most notable of those is controller-runtime, which has seen some significant rework. No semantic changes are intended in this change.

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


markusthoemmes avatar Jan 30 '24 13:01 markusthoemmes

@markusthoemmes Thanks again for the PR. There are conflicts that need to be resolved, you'll need to rebase the master

benjaminhuo avatar Jan 30 '24 13:01 benjaminhuo

Done. I was staging PRs and didn't notice the other one actually merged.

markusthoemmes avatar Jan 30 '24 13:01 markusthoemmes

Hmm. Gotta fix the code generation. Will take care of that.

markusthoemmes avatar Jan 30 '24 13:01 markusthoemmes

might need go mod tidy for this? https://github.com/fluent/fluent-operator/actions/runs/7711728924/job/21017658151?pr=1050 image

benjaminhuo avatar Jan 30 '24 13:01 benjaminhuo

Hmm. This diff is becoming much larger than intended because the PodSpec grew quiet a bit between versions, I suppose.

markusthoemmes avatar Jan 30 '24 13:01 markusthoemmes

@benjaminhuo As mentioned above, this diff has grown quite a bit. We could try to make it smaller by upgrading controller-runtime in smaller steps or trying to break the K8s upgrades out. Let me know if you'd like me to invest some effort into trying to make the diff smaller.

markusthoemmes avatar Jan 30 '24 14:01 markusthoemmes

Hmm. This diff is becoming much larger than intended because the PodSpec grew quiet a bit between versions, I suppose.

@benjaminhuo As mentioned above, this diff has grown quite a bit. We could try to make it smaller by upgrading controller-runtime in smaller steps or trying to break the K8s upgrades out. Let me know if you'd like me to invest some effort into trying to make the diff smaller.

@wanjunlei what do you think?

benjaminhuo avatar Jan 30 '24 14:01 benjaminhuo

Hmm. This diff is becoming much larger than intended because the PodSpec grew quiet a bit between versions, I suppose.

@benjaminhuo As mentioned above, this diff has grown quite a bit. We could try to make it smaller by upgrading controller-runtime in smaller steps or trying to break the K8s upgrades out. Let me know if you'd like me to invest some effort into trying to make the diff smaller.

@wanjunlei what do you think?

I think it's more appropriate to upgrade the controller runtime in smaller steps.

wanjunlei avatar Feb 18 '24 07:02 wanjunlei

@benjaminhuo As mentioned above, this diff has grown quite a bit. We could try to make it smaller by upgrading controller-runtime in smaller steps or trying to break the K8s upgrades out. Let me know if you'd like me to invest some effort into trying to make the diff smaller.

We might need to catch up with the upstream k8s community updates and drop supports for lower version K8s. The dependencies are quite obsolete, so maybe big changes are also acceptable as long as we add a k8s support metrics @markusthoemmes @wanjunlei

benjaminhuo avatar Apr 06 '24 14:04 benjaminhuo

We might need to catch up with the upstream k8s community updates and drop supports for lower version K8s.

we really need to catch up with upstream now because there're quite big differences and the code cannot compile with latest k8s dependencies:

image

benjaminhuo avatar Apr 06 '24 15:04 benjaminhuo

Fixed by https://github.com/fluent/fluent-operator/pull/1251, close this one

benjaminhuo avatar Jul 24 '24 02:07 benjaminhuo