fluent-logger-python icon indicating copy to clipboard operation
fluent-logger-python copied to clipboard

emit() does not call handleError on exception.

Open klarose opened this issue 3 years ago • 0 comments

The documentation for the handleError function of logging.Handler implies that exceptions should be caught by emit and handled by invoking handleError. This allows the environment to customer how logging errors are handled.

The fluent logger Handler does not do this: https://github.com/fluent/fluent-logger-python/blob/d1b81bafe442f9cd3059fa07da1fd8de4e92716c/fluent/handler.py#L237

The net result is that exceptions triggered when running the fluent logger (either in format or otherwise) are raised, as opposed to log, which is inconsistent with the rest of the logging Handlers.

The fluent logger should call handleError.

klarose avatar Jan 28 '21 18:01 klarose