fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

in_systemd: tests: Provide restoring way the previous behavior

Open cosmo0920 opened this issue 1 year ago • 2 comments

The revised behavior needs more memory than just serializing one-by-one way. So, for the lower memory environments or resource capped containers, we need to provide a restoring way with previous behavior. With the previous behavior, the last element on the duplicated key is only effective when encoding as JSON.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [ ] Example configuration file for the change
  • [ ] Debug log output from testing the change
  • [ ] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [ ] Run local packaging test showing all targets (including any new ones) build.
  • [ ] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [ ] Documentation required for this feature

Backporting

  • [ ] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

cosmo0920 avatar Dec 24 '24 09:12 cosmo0920

@cosmo0920 are we sure is not a memory leak ? I ask since the user reported excessive memory usage:

https://fluent-all.slack.com/archives/C0CTQGHKJ/p1734955974377129

edsiper avatar Dec 24 '24 13:12 edsiper

@cosmo0920 are we sure is not a memory leak ? I ask since the user reported excessive memory usage:

https://fluent-all.slack.com/archives/C0CTQGHKJ/p1734955974377129

Yeah, there is a possibility to be existing some of the memory leaks. But surely we increased memory usages in this plugin with using the intermediate representation via cfl kvlist.

cosmo0920 avatar Dec 24 '24 14:12 cosmo0920

Closing this as #9764 fixes the memory leak

edsiper avatar Jan 08 '25 22:01 edsiper