lib: Do not use private makefile targets in CMakelists.txt

[nikomauno]

By extending the scope of changes introduced in commit fc325524d50fe179b76f127243ab9e03ddbdaaa4 ("build: CMakeLists.txt Do not use private makefile targets (#5819)") we mitigate the following error produced by BitBake in Yocto

ERROR: fluentbit-3.1.9-r0 do_package_qa: QA Issue: File /usr/bin/fluent-bit in package fluentbit contains reference to TMPDIR [buildpaths] ERROR: fluentbit-3.1.9-r0 do_package_qa: Fatal QA errors were found, failing task.

stemming from

  $ strings packages-split/fluentbit/usr/bin/fluent-bit
  ...
  $(subst /yocto/upstream/build/tmp/work/cortexa57-poky-linux/fluentbit/3.1.9/git/,,$(abspath $<))
  ...

---

Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

• [N/A] Example configuration file for the change
• [N/A] Debug log output from testing the change

• [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

• [N/A] Run local packaging test showing all targets (including any new ones) build.
• [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

• [N/A] Documentation required for this feature

Backporting

• [X] Backport to latest stable release.

---

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

[patrick-stephens]

It looks like these are all in upstream dependencies so really should be updated there and then the new versions sync'd to Fluent Bit. I don't think this will be accepted.

[patrick-stephens]

Additionally you've made a change to Windows builds so really need to verify it functions for that target too.

[nikomauno]

Additionally you've made a change to Windows builds so really need to verify it functions for that target too.

Indeed, that was not intentional -- updated commit to avoid this from happening.

[nikomauno]

It looks like these are all in upstream dependencies so really should be updated there and then the new versions sync'd to Fluent Bit. I don't think this will be accepted.

Thank You for pointing this out, as a first time submitter I was wholly unaware of the fact.

[nikomauno]

As an update, as advised I have now opened respective upstream pull requests:

• https://github.com/monkey/monkey/pull/418
• https://github.com/fluent/ctraces/pull/61
• https://github.com/fluent/cmetrics/pull/226
• https://github.com/fluent/cfl/pull/54

[github-actions[bot]]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions[bot]]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.