fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

out_kinesis_streams: integrate with shared compression lib

Open reegnz opened this issue 1 year ago • 3 comments

Support for gzip compression. Basically copied the approach used in out_kinesis_firehose.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [ ] Example configuration file for the change
  • [ ] Debug log output from testing the change
  • [ ] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [ ] Run local packaging test showing all targets (including any new ones) build.
  • [ ] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [ ] Documentation required for this feature

Backporting

  • [ ] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

reegnz avatar Aug 13 '24 17:08 reegnz

I basically copied what got implemented in out_kinesis_firehose, but I'm sort of a C noob, so I'd appreciate some help in testing (can probably do it myself given enough time but other people are more savvy with this stuff than me).

reegnz avatar Aug 13 '24 17:08 reegnz

I want to migrate away from fluentd where this feature was present, and it's a pretty big blocker for me right now.

Original PR was #4371 where I'm backporting the compression implementation from.

@PettitWesley maybe I can get you to help out, given that you were the original implementor of the out_kinesis_stream feature?

reegnz avatar Aug 13 '24 17:08 reegnz

Opened a ticket that covers this issue: #9451

reegnz avatar Oct 01 '24 11:10 reegnz

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Jan 01 '25 02:01 github-actions[bot]

Still live. Need feedback from someone competent with the topic.

reegnz avatar Jan 02 '25 14:01 reegnz

@cosmo0920 I see you've been involved in a kinesis_output PR, maybe you could have a look?

reegnz avatar Jan 30 '25 17:01 reegnz

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Sep 06 '25 02:09 github-actions[bot]

Although stale, this is still in demand.

reegnz avatar Sep 09 '25 11:09 reegnz

It could be useful for reducing bandwidth of requesting to AWS. Do you have an ETA for finishing up to mark as ready for review?

cosmo0920 avatar Sep 10 '25 02:09 cosmo0920

Let me quote myself:

but I'm sort of a C noob, so I'd appreciate some help in testing

reegnz avatar Sep 11 '25 01:09 reegnz

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Dec 25 '25 02:12 github-actions[bot]