fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

add build support for ubuntu 24.04 noble numbat

Open markuman opened this issue 9 months ago • 7 comments

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [ ] Run local packaging test showing all targets (including any new ones) build.
  • [ ] Set ok-package-test label to test for all targets (requires maintainer to do).

Closes: #8775

markuman avatar May 06 '24 07:05 markuman

Run local packaging test showing all targets (including any new ones) build.

This failed in the master branch already for me.

Unable to find /home/m/git/fluent-bit/packaging/distros/{"target":"amazonlinux/Dockerfile

@patrick-stephens

markuman avatar May 06 '24 07:05 markuman

Run local packaging test showing all targets (including any new ones) build.

This failed in the master branch already for me.

Unable to find /home/m/git/fluent-bit/packaging/distros/{"target":"amazonlinux/Dockerfile

@patrick-stephens

Please fix it up if you can, it may be a shell issue.

patrick-stephens avatar May 07 '24 10:05 patrick-stephens

@markuman looks like it build for 24.04 - can you test the artefacts downloadable from here? https://github.com/fluent/fluent-bit/actions/runs/8983659311?pr=8796

patrick-stephens avatar May 07 '24 12:05 patrick-stephens

Also can you sort the DCO as that's required before we can merge

patrick-stephens avatar May 07 '24 12:05 patrick-stephens

Also can you sort the DCO as that's required before we can merge

Ok, done (I guess).

markuman avatar May 07 '24 13:05 markuman

hi @markuman, DCO is fine. You just need to fix the commit message :) https://github.com/fluent/fluent-bit/actions/runs/8986029386/job/24681695679?pr=8796

lecaros avatar May 11 '24 23:05 lecaros

hi @markuman, DCO is fine. You just need to fix the commit message :) https://github.com/fluent/fluent-bit/actions/runs/8986029386/job/24681695679?pr=8796

Also done (I hope so).

markuman avatar May 13 '24 07:05 markuman

Hi! Anything I can do to move this forward? :bow:

danybmx avatar May 22 '24 19:05 danybmx

The PR title was incorrect so I've updated that.

patrick-stephens avatar May 24 '24 09:05 patrick-stephens

@markuman / @danybmx could you submit a docs PR to add this to the supported targets?

patrick-stephens avatar May 28 '24 11:05 patrick-stephens

@markuman / @danybmx could you submit a docs PR to add this to the supported targets?

Something like that? https://github.com/fluent/fluent-bit/pull/8889

markuman avatar May 29 '24 07:05 markuman

Ah sorry, that's good but also to the actual docs over in the fluent-bit-docs repo

patrick-stephens avatar May 29 '24 07:05 patrick-stephens