fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

Published 20 hours ago • verified publisher icon fluent

windows: build: Enable out_kafka plugin on Windows

Open cosmo0920 opened this issue 1 year ago • 6 comments

In Windows, we forcibly disabled out_kafka plugin on Windows for OpenSSL linkage issues. Nowadays, this linkage issue seems to be fixed on CI/CD. So, I'm trying to enable this plugin on Windows.

In AppVeyor, we still didn't resolved OpenSSL linkage issue. However, we already migrated unit test for Windows on GitHub Actions. So, the existing reason of AppVeyor is maintaining for ABI or something like that?

Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [ ] Example configuration file for the change
  • [ ] Debug log output from testing the change
  • [ ] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [ ] Run local packaging test showing all targets (including any new ones) build.
  • [ ] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [ ] Documentation required for this feature

Backporting

  • [ ] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

cosmo0920 avatar Apr 03 '24 02:04 cosmo0920

I would just remove AppVeyor entirely, let's not complicate CMake because of it.

patrick-stephens avatar Apr 10 '24 10:04 patrick-stephens

Hmm..., AppVeyor CI is still alive. So, would we remove or disable AppVeyor CI from this repo?

cosmo0920 avatar Apr 11 '24 08:04 cosmo0920

Configure it not to run for PRs or similar. I think complicating CMake for it is not a good idea here.

It may be better as a separate PR just to remove AppVeyor entirely.

patrick-stephens avatar Apr 11 '24 12:04 patrick-stephens

I updated to disable almost of the AppVeyor/s CI/CD tasks. To remove this workflow or delete AppVeyor's project should be handled in the separated PR, I believe.

cosmo0920 avatar Apr 15 '24 08:04 cosmo0920

Note, once merged we need to update the release workflow as well to ensure it does not try to pull AppVeyor binaries as this will fail now.

patrick-stephens avatar Apr 18 '24 13:04 patrick-stephens

Hi, is this PR able to get merged? Because an article https://laurierhodes.info/node/156 was up to seek opportunity to use out_kafka plugin on Windows. We need to cover this case. :)

cosmo0920 avatar Apr 23 '24 06:04 cosmo0920

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Jul 24 '24 01:07 github-actions[bot]

I rethought a bit and I used vcpkg to install the latest OpenSSL libraries with x86|x64-windows-static triplet. This can resolve weird linkage errors.

cosmo0920 avatar Aug 07 '24 07:08 cosmo0920

Can you share the compiled windows zip with kafka?

yangliuqing5470 avatar Aug 07 '24 07:08 yangliuqing5470

Can you share the compiled windows zip with kafka?

This will be up on the next release. Or, unstable build will bring up them if this PR is merged.

cosmo0920 avatar Aug 07 '24 08:08 cosmo0920

Can you share the compiled windows zip with kafka?

This will be up on the next release. Or, unstable build will bring up them if this PR is merged.

OK! Thanks

yangliuqing5470 avatar Aug 07 '24 08:08 yangliuqing5470

There is no 3.1.5 in the installation documentation for windows

yangliuqing5470 avatar Aug 12 '24 02:08 yangliuqing5470