fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

in_tail: add fifo support

Open ccampo133 opened this issue 2 years ago • 11 comments

Adds support for named pipes (FIFOs) to the tail input plugin.

Addresses #6829

I haven't written any serious C in about 15+ years, so this is sort of a shot in the dark based on a previous PR (https://github.com/fluent/fluent-bit/pull/1725). That being said, it appears to work for me locally. Any help ensuring this is the correct approach to solve this problem would be appreciated.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [x] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [x] Attached Valgrind output that shows no leaks or memory corruption was found
vagrant@ubuntu-jammy:/vagrant/build$ valgrind bin/flb-rt-in_tail
==23093== Memcheck, a memory error detector
==23093== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==23093== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==23093== Command: bin/flb-rt-in_tail
==23093==
Test issue_3943...                              [ OK ]
Test skip_long_lines...                         [ OK ]
Test path_comma...                              [2023/02/15 16:09:52] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:09:52] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:09:52] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:09:52] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:09:52] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:09:52] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:09:53] [ info] [sp] stream processor started
[2023/02/15 16:09:53] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24689 watch_fd=1 name=a.log
[2023/02/15 16:09:53] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24690 watch_fd=2 name=b.log
[2023/02/15 16:09:53] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24691 watch_fd=3 name=c.log
[2023/02/15 16:09:53] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24692 watch_fd=4 name=d.log
[2023/02/15 16:09:54] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24689 watch_fd=1
[2023/02/15 16:09:54] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24690 watch_fd=2
[2023/02/15 16:09:54] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24691 watch_fd=3
[2023/02/15 16:09:54] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24692 watch_fd=4
[2023/02/15 16:09:55] [ warn] [engine] service will shutdown in max 1 seconds
[2023/02/15 16:09:55] [ info] [input] pausing tail.0
[2023/02/15 16:09:55] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:09:55] [ info] [input] pausing tail.0
[ OK ]
Test path_key...                                [2023/02/15 16:09:55] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:09:55] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:09:55] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:09:55] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:09:55] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:09:55] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:09:55] [ info] [sp] stream processor started
[2023/02/15 16:09:55] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24693 watch_fd=1 name=path_key.log
[2023/02/15 16:09:56] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24693 watch_fd=1
[2023/02/15 16:09:57] [ warn] [engine] service will shutdown in max 1 seconds
[2023/02/15 16:09:57] [ info] [input] pausing tail.0
[2023/02/15 16:09:57] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:09:57] [ info] [input] pausing tail.0
[ OK ]
Test exclude_path...                            [2023/02/15 16:09:57] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:09:57] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:09:57] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:09:57] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:09:57] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:09:57] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:09:57] [ info] [sp] stream processor started
[2023/02/15 16:09:57] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24696 watch_fd=1 name=ep_file1.txt
[2023/02/15 16:09:57] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24697 watch_fd=2 name=ep_file2.txt
[2023/02/15 16:09:57] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24698 watch_fd=3 name=ep_file3.txt
[2023/02/15 16:09:59] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24696 watch_fd=1
[2023/02/15 16:09:59] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24697 watch_fd=2
[2023/02/15 16:09:59] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24698 watch_fd=3
[2023/02/15 16:10:00] [ warn] [engine] service will shutdown in max 1 seconds
[2023/02/15 16:10:00] [ info] [input] pausing tail.0
[2023/02/15 16:10:00] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:10:00] [ info] [input] pausing tail.0
[ OK ]
Test offset_key...                              [2023/02/15 16:10:01] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:10:01] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:10:01] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:10:01] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:10:01] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:10:01] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:10:01] [ info] [sp] stream processor started
[2023/02/15 16:10:01] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24699 watch_fd=1 name=offset_key.log
[2023/02/15 16:10:01] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24699 watch_fd=1
[2023/02/15 16:10:02] [ warn] [engine] service will shutdown in max 1 seconds
[2023/02/15 16:10:02] [ info] [input] pausing tail.0
[2023/02/15 16:10:03] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:10:03] [ info] [input] pausing tail.0
[ OK ]
Test skip_empty_lines...                        [2023/02/15 16:10:04] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:10:04] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:10:04] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:10:04] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:10:04] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:10:04] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:10:04] [ info] [sp] stream processor started
[2023/02/15 16:10:04] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24700 watch_fd=1 name=skip_empty_lines.log
[2023/02/15 16:10:05] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24700 watch_fd=1
[2023/02/15 16:10:06] [ warn] [engine] service will shutdown in max 1 seconds
[2023/02/15 16:10:06] [ info] [input] pausing tail.0
[2023/02/15 16:10:06] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:10:06] [ info] [input] pausing tail.0
[ OK ]
Test ignore_older...                            [2023/02/15 16:10:06] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:10:06] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:10:06] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:10:06] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:10:06] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:10:06] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:10:06] [ info] [sp] stream processor started
[2023/02/15 16:10:06] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24701 watch_fd=1 name=time_now.log
[2023/02/15 16:10:08] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24701 watch_fd=1
[2023/02/15 16:10:09] [ warn] [engine] service will shutdown in max 1 seconds
[2023/02/15 16:10:09] [ info] [input] pausing tail.0
[2023/02/15 16:10:09] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:10:09] [ info] [input] pausing tail.0
[2023/02/15 16:10:09] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:10:09] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:10:09] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:10:09] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:10:09] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:10:09] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:10:09] [ info] [sp] stream processor started
[2023/02/15 16:10:09] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24706 watch_fd=1 name=time_30m.log
[2023/02/15 16:10:09] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24705 watch_fd=2 name=time_now.log
[2023/02/15 16:10:11] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24705 watch_fd=2
[2023/02/15 16:10:11] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24706 watch_fd=1
[2023/02/15 16:10:12] [ warn] [engine] service will shutdown in max 1 seconds
[2023/02/15 16:10:12] [ info] [input] pausing tail.0
[2023/02/15 16:10:12] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:10:12] [ info] [input] pausing tail.0
[2023/02/15 16:10:12] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:10:12] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:10:12] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:10:12] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:10:12] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:10:12] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:10:12] [ info] [sp] stream processor started
[2023/02/15 16:10:12] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24710 watch_fd=1 name=time_30m.log
[2023/02/15 16:10:12] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24711 watch_fd=2 name=time_3h.log
[2023/02/15 16:10:12] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24709 watch_fd=3 name=time_now.log
[2023/02/15 16:10:14] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24709 watch_fd=3
[2023/02/15 16:10:14] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24710 watch_fd=1
[2023/02/15 16:10:14] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24711 watch_fd=2
[2023/02/15 16:10:15] [ warn] [engine] service will shutdown in max 1 seconds
[2023/02/15 16:10:15] [ info] [input] pausing tail.0
[2023/02/15 16:10:15] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:10:15] [ info] [input] pausing tail.0
[2023/02/15 16:10:15] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:10:15] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:10:15] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:10:15] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:10:15] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:10:15] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:10:15] [ info] [sp] stream processor started
[2023/02/15 16:10:15] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24714 watch_fd=1 name=time_30m.log
[2023/02/15 16:10:15] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24716 watch_fd=2 name=time_3d.log
[2023/02/15 16:10:15] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24715 watch_fd=3 name=time_3h.log
[2023/02/15 16:10:15] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24713 watch_fd=4 name=time_now.log
[2023/02/15 16:10:17] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24713 watch_fd=4
[2023/02/15 16:10:17] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24714 watch_fd=1
[2023/02/15 16:10:17] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24715 watch_fd=3
[2023/02/15 16:10:17] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24716 watch_fd=2
[2023/02/15 16:10:18] [ warn] [engine] service will shutdown in max 1 seconds
[2023/02/15 16:10:18] [ info] [input] pausing tail.0
[2023/02/15 16:10:18] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:10:18] [ info] [input] pausing tail.0
[ OK ]
Test inotify_watcher_false...                   [2023/02/15 16:10:18] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:10:18] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:10:18] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:10:18] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:10:18] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:10:18] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:10:18] [ info] [sp] stream processor started
[2023/02/15 16:10:20] [error] [/vagrant/plugins/in_tail/tail_fs_stat.c:67 errno=2] No such file or directory
[2023/02/15 16:10:21] [ warn] [engine] service will shutdown in max 1 seconds
[2023/02/15 16:10:21] [ info] [input] pausing tail.0
[2023/02/15 16:10:21] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:10:21] [ info] [input] pausing tail.0
[ OK ]
Test parser...                                  [2023/02/15 16:10:21] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:10:21] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:10:21] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:10:21] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:10:21] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:10:21] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:10:21] [ info] [sp] stream processor started
[2023/02/15 16:10:21] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24718 watch_fd=1 name=parser.log
[2023/02/15 16:10:22] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24718 watch_fd=1
[2023/02/15 16:10:23] [ warn] [engine] service will shutdown in max 1 seconds
[2023/02/15 16:10:23] [ info] [input] pausing tail.0
[2023/02/15 16:10:23] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:10:23] [ info] [input] pausing tail.0
[ OK ]
Test tag_regex...                               [2023/02/15 16:10:23] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:10:23] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:10:23] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:10:23] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:10:23] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:10:23] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:10:23] [ info] [sp] stream processor started
[2023/02/15 16:10:23] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24719 watch_fd=1 name=aa_bb_cc.log
[2023/02/15 16:10:24] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24719 watch_fd=1
[2023/02/15 16:10:25] [ warn] [engine] service will shutdown in max 1 seconds
[2023/02/15 16:10:25] [ info] [input] pausing tail.0
[2023/02/15 16:10:25] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:10:25] [ info] [input] pausing tail.0
[ OK ]
Test db...                                      [2023/02/15 16:10:25] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:10:25] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:10:25] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:10:25] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:10:25] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:10:25] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:10:26] [ info] [sp] stream processor started
[2023/02/15 16:10:26] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24720 watch_fd=1 name=test_db.log
[2023/02/15 16:10:27] [ warn] [engine] service will shutdown in max 1 seconds
[2023/02/15 16:10:27] [ info] [input] pausing tail.0
[2023/02/15 16:10:27] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:10:27] [ info] [input] pausing tail.0
[2023/02/15 16:10:27] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24720 watch_fd=1
[2023/02/15 16:10:28] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:10:28] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:10:28] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:10:28] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:10:28] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:10:28] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:10:28] [ info] [sp] stream processor started
[2023/02/15 16:10:28] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24720 watch_fd=1 name=test_db.log
[2023/02/15 16:10:29] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24720 watch_fd=1
[2023/02/15 16:10:30] [ warn] [engine] service will shutdown in max 1 seconds
[2023/02/15 16:10:30] [ info] [input] pausing tail.0
[2023/02/15 16:10:30] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:10:30] [ info] [input] pausing tail.0
[ OK ]
Test in_tail_dockermode...                      [ OK ]
Test in_tail_dockermode_splitted_line...        [ OK ]
Test in_tail_dockermode_multiple_lines...       [ OK ]
Test in_tail_dockermode_splitted_multiple_lines... [ OK ]
Test in_tail_dockermode_firstline_detection...  [ OK ]
Test in_tail_multiline_json_and_regex...        [2023/02/15 16:10:47] [ info] [fluent bit] version=2.0.9, commit=5f52a5eacb, pid=23093
[2023/02/15 16:10:47] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/02/15 16:10:47] [ info] [cmetrics] version=0.5.8
[2023/02/15 16:10:47] [ info] [ctraces ] version=0.2.7
[2023/02/15 16:10:47] [ info] [input:tail:tail.0] initializing
[2023/02/15 16:10:47] [ info] [input:tail:tail.0] storage_strategy='memory' (memory only)
[2023/02/15 16:10:47] [ info] [input:tail:tail.0] multiline core started
[2023/02/15 16:10:47] [ info] [sp] stream processor started
[2023/02/15 16:10:47] [ info] [input:tail:tail.0] inotify_fs_add(): inode=24740 watch_fd=1 name=/vagrant/tests/runtime/data/tail/log/multiline_001.log
[2023/02/15 16:10:51] [ warn] [engine] service will shutdown in max 5 seconds
[2023/02/15 16:10:51] [ info] [input] pausing tail.0
[2023/02/15 16:10:52] [ info] [engine] service has stopped (0 pending tasks)
[2023/02/15 16:10:52] [ info] [input] pausing tail.0
[2023/02/15 16:10:52] [ info] [input:tail:tail.0] inotify_fs_remove(): inode=24740 watch_fd=1
[ OK ]
SUCCESS: All unit tests have passed.
==23093==
==23093== HEAP SUMMARY:
==23093==     in use at exit: 0 bytes in 0 blocks
==23093==   total heap usage: 74,477 allocs, 74,477 frees, 24,744,744 bytes allocated
==23093==
==23093== All heap blocks were freed -- no leaks are possible
==23093==
==23093== For lists of detected and suppressed errors, rerun with: -s
==23093== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [ ] Documentation required for this feature

Backporting

  • [ ] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

ccampo133 avatar Feb 10 '23 22:02 ccampo133

Thanks for this @ccampo133 , could you just ensure your commits are signed and follow the contribution guidelines for the commit message?

patrick-stephens avatar Feb 14 '23 18:02 patrick-stephens

@patrick-stephens thanks, I just updated my commit.

ccampo133 avatar Feb 14 '23 19:02 ccampo133

We'll need a valgrind report as well to ensure no leaks.

patrick-stephens avatar Feb 15 '23 07:02 patrick-stephens

@patrick-stephens, thanks, I attached the Valgrind output against the flb-rt-in_tail test, since my change only impacts that plugin. I hope this is sufficient.

ccampo133 avatar Feb 15 '23 16:02 ccampo133

Note that https://github.com/fluent/fluent-bit/pull/6831/files#diff-3f732b7c34db5e1907a87e8bc0da90c32d480c918589d10c0194f8f7fe91317fL64-R64 appears to be a typo in the original code.

ccampo133 avatar Mar 10 '23 15:03 ccampo133

Ignore the appveyor failure due to a flaky test - this is fixed on latest master I believe as well.

patrick-stephens avatar Mar 28 '23 10:03 patrick-stephens

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Jun 27 '23 02:06 github-actions[bot]

Hi there @ccampo133! Is there any news on this one? I have a similar need and noticed this issue got stale just a few days ago :(

adirmatzkin avatar Jun 30 '23 19:06 adirmatzkin

This PR will not be merged in the foreseeable future, for the moment you can use the in_exec input plugin in threaded mode in order to achieve the same result.

leonardo-albertovich avatar Jul 01 '23 15:07 leonardo-albertovich

@adirmatzkin please see https://github.com/fluent/fluent-bit/issues/6829 for some discussion and a potential work-around. It's unfortunate that the ticket was closed as stale. I ended up taking a different approach to solve my problem (which prompted the issue) without using named pipes.

Note that you can still use the code in this PR if you want to give it a shot and compile Fluent Bit yourself. If you want to use the latest version of FB, I would just use this as a guide and make any necessary changes to the tail plugin. It is pretty straightforward to build FB from source.

ccampo133 avatar Jul 03 '23 16:07 ccampo133

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Oct 02 '23 01:10 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 27 '24 02:11 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Aug 28 '25 02:08 github-actions[bot]