out_s3: use configured retry_limit instead of hardcoded MAX_UPLOAD_ERRORS and update the warn message

[Claych]

trafficstars

Signed-off-by: Clay Cheng [email protected]

---

Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

• [x] Example configuration file for the change [OUTPUT] Name s3 Match * bucket clay-bucket-5-s3-test region us-east-1 total_file_size 60M auto_retry_requests true use_put_object off upload_chunk_size 5M
• [x] Debug log output from testing the change

• [x] Attached Valgrind output that shows no leaks or memory corruption was found Test result when connected with s3:

Test results when disconnected from s3:

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

• [ ] Attached local packaging test output showing all targets (including any new ones) build.

Documentation

• [ ] Documentation required for this feature

Backporting

• [ ] Backport to latest stable release.

---

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

[PettitWesley]

@Claych I think a commit message that makes it more clear why we made this change would be something like: out_s3: use configured retry_limit instead of hardcoded MAX_UPLOAD_ERRORS

[Claych]

@Claych I think a commit message that makes it more clear why we made this change would be something like: out_s3: use configured retry_limit instead of hardcoded MAX_UPLOAD_ERRORS

updated

[PettitWesley]

@Claych The commit messages are used to create the changelog, that's why its important they are clear and end-user friendly IMO. Please change the commit message to something like what you made the title.

[PettitWesley]

@Claych when this is ready to merge, this should be one commit.

[github-actions[bot]]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions[bot]]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.