fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

in_tcp: user friendly warn message for skipping records

Open PettitWesley opened this issue 3 years ago • 1 comments

Signed-off-by: Wesley Pettit [email protected]


Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [ ] Example configuration file for the change
  • [ ] Debug log output from testing the change
  • [ ] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [ ] Attached local packaging test output showing all targets (including any new ones) build.

Documentation

  • [ ] Documentation required for this feature

Backporting

  • [ ] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

PettitWesley avatar Sep 16 '22 20:09 PettitWesley

@edsiper I have seen a lot of users get confused by this. At first I was going to make this a debug message, but I really strongly advocate that users need to see these messages as a warning/error/problem since FB is skipping logs.

Master PR: https://github.com/fluent/fluent-bit/pull/6062/files

https://github.com/aws/aws-for-fluent-bit/blob/mainline/troubleshooting/debugging.md#chunk_size-and-buffer_size-for-large-logs-in-tcp-input

PettitWesley avatar Sep 16 '22 20:09 PettitWesley

@lecaros @edsiper CI passes. Any reason we can't merge this small usability improvement?

PettitWesley avatar Oct 05 '22 16:10 PettitWesley