fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

Suggesting to Revisit #2498

Open GLStephen opened this issue 2 years ago • 2 comments

There is an existing bug reporting which went stale.

https://github.com/fluent/fluent-bit/issues/2498

I suggest revisiting this item. Auto conversion of this type is causing major issues for us with guids that contain numbers and letters. If the GUID starts with a number then it converts it to an integer. There seems to be no way to disable this auto conversion other than to prepend values with junk data.

GLStephen avatar Jun 23 '22 19:06 GLStephen

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.

github-actions[bot] avatar Sep 22 '22 02:09 github-actions[bot]

No response? This should be reconsidered. Magic handling of conversion of data types that truncates data at the ingestion layer is bad form. Magic conversion to a data type (string for instance) that maintains the data is much more interoperable.

GLStephen avatar Sep 22 '22 09:09 GLStephen

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.

github-actions[bot] avatar Dec 23 '22 02:12 github-actions[bot]

I hit exactly the same issue. The conversion of strings into integers is:

  • undocumented
  • not being implemented correctly

I would invite an implementation which does conversion to integer only on numbers.

vlcinsky avatar Dec 28 '22 18:12 vlcinsky

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.

github-actions[bot] avatar Mar 29 '23 02:03 github-actions[bot]

Still not really stale!

GLStephen avatar Mar 29 '23 02:03 GLStephen

@GLStephen We are facing this issue as well. This is a really bad implementation of forced type conversion. Any String that starts with numbers (most uids) are being converted to numbers. Do you have any workarounds for this?

sameerchandra avatar Apr 26 '23 19:04 sameerchandra

@sameerchandra not a good one, we added a string value "::" to the front of our GUIDs at the ingestion point so that they are always processed as strings, then we pull that out later in a later transformation process. It's not ideal for sure.

@leonardo-albertovich any way to get this prioritized or considered?

GLStephen avatar Apr 26 '23 19:04 GLStephen

TBH I'm the least knowledgeable around when it comes to the SP, I don't even know how to use it but if you are willing to help me get started with the SP and reproduce the issue I'll give it a try next week (sorry but I'm completely booked this week).

leonardo-albertovich avatar Apr 26 '23 19:04 leonardo-albertovich

@leonardo-albertovich I saw you on some merges and thought I would reach out to someone who at least seemed more active on the project. Would you recommend I reach out to someone else on the project? Fixing it is one thing, but at least getting it evaluated as "will fix" in the near term would be nice.

GLStephen avatar Apr 26 '23 19:04 GLStephen

@leonardo-albertovich I can reliably reproduce this issue. Let me know if you need more details.

@GLStephen thanks for suggesting a workaround. Think we will do that for now

sameerchandra avatar Apr 26 '23 19:04 sameerchandra

Let's take a look at it next week to determine the complexity of the issue and then we'll see if it's something I can fix or if it's something we can ping past contributors about.

As for the reproduction, I'd really appreciate it if you shared it with me @sameerchandra but please be aware that I won't be able to look at it until next week.

Feel free to reach out to me in slack or tag me again if you want to stay on top of it.

leonardo-albertovich avatar Apr 26 '23 20:04 leonardo-albertovich

@leonardo-albertovich thanks for the response. I will provide the required details for reproducing the issue and also understand that you won't be able to look into this till next week.

sameerchandra avatar Apr 27 '23 04:04 sameerchandra

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.

github-actions[bot] avatar Jul 27 '23 01:07 github-actions[bot]

Please add exempt-stale to this item. This is important to resolve. @leonardo-albertovich

GLStephen avatar Jul 27 '23 02:07 GLStephen

Note: https://github.com/fluent/fluent-bit/pull/7005 is merged into master.

nokute78 avatar Sep 24 '23 01:09 nokute78

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.

github-actions[bot] avatar Dec 23 '23 01:12 github-actions[bot]

This issue was closed because it has been stalled for 5 days with no activity.

github-actions[bot] avatar Dec 28 '23 01:12 github-actions[bot]