fluent-bit
fluent-bit copied to clipboard
fluent
build: enable in_kafka and out_kafka by default
@agup006 I've enabled kafka plugins by default, but not on Windows since it causes a build error on CI
What's the build error?
Looks like it doesn't like some of the void* usage: https://ci.appveyor.com/project/fluent/fluent-bit-2e87g/builds/43155542/job/yyye570bjrb67uvg#L2827
Fixed the issue with windows build, just replacing offsetof by container_of macro took care of windows incompatibility
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
@edsiper @fujimotos @koleini @leonardo-albertovich, could we get this reviewed/merged so the next release will have the kafka plugins enabled by default?
@tarruda please disable for Windows if it does not compile: https://github.com/fluent/fluent-bit/blob/master/cmake/windows-setup.cmake
@patrick-stephens rebased and fixed the builds. Couldn't enable by default on windows because the build fails on missing libcrypto, which I assume is a librdkafka dependency.
These changes are a hard requirement for this PR to be merged.
@leonardo-albertovich it seems the windows-specific cmake is not being applied during CI since appveyor tried to build it. Do you know what I might have missed?
@leonardo-albertovich nevermind, it was a typo in windows-setup.cmake. Can you approve again?