fluent-bit
fluent-bit copied to clipboard
in_forward: check return status of flb_input_chunk_append_raw before ACK
Signed-off-by: Aaron Epstein [email protected]
Forward input plugin would send an acknowledgement back even if the data could not be appended to a chunk. This changes in_forward to not send an ACK if there was a failure in flb_input_chunk_append_raw.
Enter [N/A]
in the box, if an item is not applicable to your change.
Testing Before we can approve your change; please submit the following in a comment:
- [N/A] Example configuration file for the change
- [N/A] Debug log output from testing the change
- [N/A] Attached Valgrind output that shows no leaks or memory corruption was found
Documentation
- [ ] Documentation required for this feature
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
Commenting since this went stale. @leonardo-albertovich @edsiper Do you have any concerns about this change?
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
This is a small change that will help make the forward input more transactional. @leonardo-albertovich @edsiper Can you take a look?
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.