fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

out_pgsql: dynamic load library on windows

Open costinmrr opened this issue 4 years ago • 4 comments

This is in response to the changes requested in https://github.com/fluent/fluent-bit/pull/3811. If we're on the right path with these changes, I will edit the documentation and go on to meet the requirements so the PR can be accepted.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • n/a Example configuration file for the change
  • [ ] Debug log output from testing the change
  • n/a Attached Valgrind output that shows no leaks or memory corruption was found

Documentation

  • [ ] Documentation required for this feature

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

costinmrr avatar Nov 03 '21 10:11 costinmrr

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Dec 05 '21 01:12 github-actions[bot]

Hi. When this support will be merged? We wanted to use it in our app but unfortunately its running on windows. Also could you mention this issue in your docs? I spent half of day looking why pqsql is not working.

Worek avatar Dec 23 '21 10:12 Worek

@fujimotos this PR addresses the issues you raised in #3811. Curious to hear your opinion on these changes and also whether there's anything we can do to get this merged. Thanks!

hongaar avatar Dec 24 '21 09:12 hongaar

@costinmrr can you fix the DCO issue and also squash your commits so we can review only one package?

sxd avatar Feb 04 '22 17:02 sxd