out_es: read port if present in cloud_host
Fixes #3920
Unfortunately, I was unable to compile the project on my macOS, so I was unable to test.
Enter [N/A] in the box, if an item is not applicable to your change.
Testing Before we can approve your change; please submit the following in a comment:
- [N/A] Example configuration file for the change
- [N/A] Debug log output from testing the change
- [N/A] Attached Valgrind output that shows no leaks or memory corruption was found
Documentation
- [N/A] Documentation required for this feature
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
Hi @edsiper, Can you take a look at this Pull Request?
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
Hi @edsiper, Can you take a look at this Pull Request?
@pettitwesley @edsiper Can you guys take a look at this? The Cloud_ID property is unusable in its current state.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
@PettitWesley @edsiper any news ?
@euskadi31 Please squash to a single commit
@PettitWesley Thank You
Hi @nokute78, do you have some time to look at this pull-request?
Thank You
@euskadi31 I think strtol sets endptr which points NULL terminator.
#include <stdio.h>
#include <stdlib.h>
int main(void) {
char *str = "1234";
int val = 0;
char *endptr = NULL;
val = (int)strtol((const char*)str, &endptr, 10);
printf("str =%p\n", str);
printf("endptr=%p\n", endptr);
printf("val=%d, endptr_char=0x%x\n", val, *endptr);
return 0;
}
taka@locals:~/git/tmp/fluent-bit/build$ gcc ~/a.c
taka@locals:~/git/tmp/fluent-bit/build$ ./a.out
str =0x5622eecdd004
endptr=0x5622eecdd008
val=1234, endptr_char=0x0
cloud_host contains port number after processing.
cloud_hostcontains port number after processing.
Ok, I look at it quickly.
Thank You @nokute78
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
@euskadi31 Could you indicate what is the status of this? This seems to solve #4260
sorry, unfortunately I don't have time to deal with this
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.