fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

out_es: read port if present in cloud_host

Open euskadi31 opened this issue 4 years ago • 17 comments

Fixes #3920

Unfortunately, I was unable to compile the project on my macOS, so I was unable to test.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

Documentation

  • [N/A] Documentation required for this feature

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

euskadi31 avatar Aug 06 '21 14:08 euskadi31

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Sep 10 '21 01:09 github-actions[bot]

Hi @edsiper, Can you take a look at this Pull Request?

euskadi31 avatar Sep 10 '21 09:09 euskadi31

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Oct 11 '21 01:10 github-actions[bot]

Hi @edsiper, Can you take a look at this Pull Request?

euskadi31 avatar Oct 11 '21 12:10 euskadi31

@pettitwesley @edsiper Can you guys take a look at this? The Cloud_ID property is unusable in its current state.

robinkb avatar Oct 15 '21 10:10 robinkb

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 15 '21 01:11 github-actions[bot]

@PettitWesley @edsiper any news ?

euskadi31 avatar Nov 15 '21 07:11 euskadi31

@euskadi31 Please squash to a single commit

PettitWesley avatar Nov 15 '21 21:11 PettitWesley

@PettitWesley Thank You

euskadi31 avatar Nov 15 '21 22:11 euskadi31

Hi @nokute78, do you have some time to look at this pull-request?

Thank You

euskadi31 avatar Dec 09 '21 10:12 euskadi31

@euskadi31 I think strtol sets endptr which points NULL terminator.

#include <stdio.h>
#include <stdlib.h>


int main(void) {
  char *str = "1234";
  int val = 0;
  char *endptr = NULL;

  val = (int)strtol((const char*)str, &endptr, 10);
  printf("str   =%p\n", str);
  printf("endptr=%p\n", endptr);
  printf("val=%d, endptr_char=0x%x\n", val, *endptr);

  return 0;
}

taka@locals:~/git/tmp/fluent-bit/build$ gcc ~/a.c
taka@locals:~/git/tmp/fluent-bit/build$ ./a.out 
str   =0x5622eecdd004
endptr=0x5622eecdd008
val=1234, endptr_char=0x0

nokute78 avatar Dec 11 '21 01:12 nokute78

cloud_host contains port number after processing.

nokute78 avatar Dec 11 '21 01:12 nokute78

cloud_host contains port number after processing.

Ok, I look at it quickly.

Thank You @nokute78

euskadi31 avatar Dec 13 '21 14:12 euskadi31

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Mar 14 '22 01:03 github-actions[bot]

@euskadi31 Could you indicate what is the status of this? This seems to solve #4260

030 avatar May 13 '22 09:05 030

sorry, unfortunately I don't have time to deal with this

euskadi31 avatar May 13 '22 10:05 euskadi31

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Aug 13 '22 02:08 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 26 '24 02:11 github-actions[bot]