fluent-bit
fluent-bit copied to clipboard
Namespace support for fluentbit.io/exclude annotation
Is your feature request related to a problem? Please describe.
Currently fluentbit.io/exclude annotation works only with pods. We have a scenario in which we want to ignore all of the pods in given namespaces. Putting fluentbit.io/exclude annotation to each pod is overhead and it will lead to restart (the old pod will be evicted and a new pod with the given annotation will be launched).
Describe the solution you'd like
It would be great if we can annotate namespace with fluentbit.io/exclude: true and fluent-bit stops to track the pods in this namespace.
Describe alternatives you've considered
Additional context
fluent-plugin-kubernetes_metadata_filter for Fluentd also reads the namespace labels and annotations.
Any updates?
Hi all, any updates on this issue, I would like to see this feature in a fluent bit, it'll be very convenient to have this rather than doing multiple filters to achieve this.
@edsiper any feedback about this?
Hi all, wondering if there's any update on this, or if anyone came across a workaround for it? Thanks
Hi, wondering if there's any update on this ?
@edsiper @niedbalski is there any chance of receiving feedback regarding this issue?
This would be amazing.
@edsiper @niedbalski any news?
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.
anyone?
@edsiper could you please take a look to this?
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.
@edsiper could you please take a look to this?
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.
@edsiper could you share your opinion about it?
This is really needed, otherwise we end up having large amount of filters...
Any update on this feature
would be nice if there would be a feature for it, dealing with all the filters isn't optimal especially once trying to template it all
@edsiper @koleini @fujimotos @PettitWesley @clamoriniere @sxd @niedbalski who should we ask for feedback on this?
Maybe @nokute78 @leonardo-albertovich @patrick-stephens @pwhelan @cosmo0920 @DavidKorczynski @tarruda ?
A much-needed functionality. The current addition of fluentbit.io/exclude is very complicated and difficult to implement with a large number of pods. With hundreds of pods it is very difficult. Please add exclude for namespace very much.
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.
@edsiper it seems incredible that such a requested feature has little feedback from the maintainers.
It would be good if we took a few steps back and switched to a more constructive approach don't you think?
I am not familiar with the topic but would be glad to help if anyone submitted a PR or at least a detailed enhancement proposal to steer this into the right direction.
@leonardo-albertovich indeed, patiently waiting 1469 days to get feedback from one of the maintainers on the feasibility of the feature request is an undesirable attitude.
A thousand days ago, it would have been enough to write something like: "Guys, a nice idea! Unfortunately, we maintainers can't develop this feature. But anyone who feels able to do so can open a PR, and we'll be happy to review it".
Is anyone working on a PR for this soo much-needed feature? I would like to help.
@chrismedinapy I estimate that no one is working on it. So if you want to do it, it is certainly welcome.
any news here?
So, what would be the best "workaround" today to solve this problem?
I found the following so far but none of them are good enough for complex envs:
- add the annotation to each pod (I guess, this could be "automated" by a mutation controller for given namespaces). This cannot handle cases when you have multiple outputs (like we have syslog and ES) and you want to be able to select which one to use
- exclude the namespaces from tail with Exclude_Path. The INPUT is not the right place to exclude things again as with 2 outputs, you cannot "select" where to send the logs (on top of this, It would be difficult to automate this)
Question for more advanced users then me: would it be possible to write a filter that adds an extra tag based on namespace annotations to the logs that then can be filtered on the output level with Match_Regex?
Namespace annotations/labels will be available in FB 3.0 from the K8S filter so @Cajga that may be possible.