fluent-bit-docs icon indicating copy to clipboard operation
fluent-bit-docs copied to clipboard

Published 20 hours ago • verified publisher icon fluent

monitoring: add detailed descriptions for each metric

Open PettitWesley opened this issue 3 years ago • 2 comments

PLEASE HELP CHECK IF MY DESCRIPTIONS ARE CORRECT, ESPECIALLY FOR THE STORAGE METRICS.

Signed-off-by: Wesley Pettit [email protected]

PettitWesley avatar Aug 02 '22 00:08 PettitWesley

cc: @lecaros

edsiper avatar Aug 02 '22 00:08 edsiper

@DrewZhang13 that seems to be something weird the markdown table generation thing I used added... thanks, I will fix it

PettitWesley avatar Aug 03 '22 20:08 PettitWesley

This would be good to merge, are we ok now @PettitWesley @DrewZhang13 @lecaros ?

patrick-stephens avatar Aug 17 '22 10:08 patrick-stephens

@patrick-stephens @lecaros I want someone outside of my own team (So not Drew) to validate that this is all correct (with an approval) before we merge it.

PettitWesley avatar Aug 17 '22 19:08 PettitWesley

Hi everyone, sorry I didn't send the review. I just left it there pending. Besides those 2 changes (fluentbit_output_proc_records_total and fluentbit_output_proc_bytes_total), the docs are great!

lecaros avatar Aug 17 '22 20:08 lecaros

@lecaros thanks. I updated it. If you can approve now then we can merge.

PettitWesley avatar Aug 17 '22 21:08 PettitWesley

Thanks for your contribution @PettitWesley! I've merged it.

lecaros avatar Aug 18 '22 15:08 lecaros